Re: [PATCH v5 0/6] drm/atomic: track individual colorop updates

[Melissa Wen <mwen@igalia.com>]

On 06/05/2026 21:23, Melissa Wen wrote:
> This series aims to track updates for each individual color operation,
> allowing the driver to react accordingly.
>
> - Patches 1 and 2 make colorop update process more consistent and
>    optimized by only keeping colorop states from active color pipelines.
>
> - Patches 3 and 4 make lut1d_interpolation and lut3d_interpolation
>    colorops correctly behave as mutable, handling their changes via
>    drm_colorop_state.
>
> - Finally, patches 5 and 6 track colorop updates of a given plane color
>    pipeline by setting plane `color_mgmt_changed` flag, similar to what
>    is done for tracking CRTC color mgmt property changes with CRTC
>    `color_mgmt_changed` flag. The flag also tracks when a different color
>    pipeline is set to a given plane. That way, the driver can react
>    accordingly and update their color blocks.
>
> It also fixes shaper/3D LUT updates when changing night mode settings on
> gamescope with a custom branch that supports `COLOR_PIPELINE`:
> - https://github.com/ValveSoftware/gamescope/pull/2113

Hey, Chaitanya, Alex H. and Harry,

Would you have some time to review this series?
I kept r-b from Harry in the last two patches that fix night mode 
persistence on AMD, but they depend on the first four patches that 
address Chaitanya's suggestions for optimizing colorop updates by active 
pipeline and also make LUT interpolation properties correctly behave as 
mutable.

Thanks in advance,

Melissa

>
> v1: https://lore.kernel.org/dri-devel/20260318162348.299807-1-mwen@igalia.com/
> Changes:
> - include linux types for function's bool return type (kernel bot on MSM
>    driver)
> - add Harry's r-b tags
>
> v2: https://lore.kernel.org/dri-devel/20260323131942.494217-1-mwen@igalia.com/
> Changes:
> - [NEW] two patches to only consider colorop updates from active color
>    pipelines (Chaitanya)
> - [NEW] make lut interpolation properties mutable + Alex H patch for
>    kernel docs
> - track lut(1/3)d_interpolation updates (Chaitanya)
> - rebase changes according to new patches
>
> v3: https://lore.kernel.org/dri-devel/20260403135909.214378-1-mwen@igalia.com/
> Changes: rebase on drm-misc-next
>
> v4: https://lore.kernel.org/dri-devel/20260501132527.522320-1-mwen@igalia.com/
> Changes: fix kernel doc (kernel bot)
>
> Melissa Wen
>
> Alex Hung (1):
>    drm/colorop: Remove read-only comments from interpolation fields
>
> Melissa Wen (5):
>    drm/atomic: only add colorop state from active color pipeline
>    drm/atomic: don't set colorop properties of inactive color pipelines
>    drm/colorop: make lut(1/3)d_interpolation mutable
>    drm/atomic: track individual colorop updates
>    drm/amd/display: use plane color_mgmt_changed to track colorop changes
>
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  6 +-
>   drivers/gpu/drm/drm_atomic.c                  | 43 +++++----
>   drivers/gpu/drm/drm_atomic_helper.c           |  9 +-
>   drivers/gpu/drm/drm_atomic_uapi.c             | 93 +++++++++++++++----
>   drivers/gpu/drm/drm_colorop.c                 | 16 +++-
>   include/drm/drm_atomic.h                      |  2 +-
>   include/drm/drm_atomic_uapi.h                 |  4 +-
>   include/drm/drm_colorop.h                     | 34 ++++---
>   8 files changed, 136 insertions(+), 71 deletions(-)
>