[PATCH] drm/amdgpu: Make amdgpu_ring_mux functions as static

[PATCH] drm/amdgpu: Make amdgpu_ring_mux functions as static

[jiadong.zhu]

From: Jiadong Zhu <Jiadong.Zhu@amd.com>

lkp robot reported missing-prototypes and unused-but-set-variable warnings on
some functions of amdgpu_mcbp_mux.c. Make them static and remove the unused
variable.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jiadong Zhu <Jiadong.Zhu@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c
index 3348337379da..62079f0e3ee8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c
@@ -350,7 +350,7 @@ unsigned int amdgpu_sw_ring_priority(int idx)
 }
 
 /*Scan on low prio rings to have unsignaled fence and high ring has no fence.*/
-int amdgpu_mcbp_scan(struct amdgpu_ring_mux *mux)
+static int amdgpu_mcbp_scan(struct amdgpu_ring_mux *mux)
 {
 	struct amdgpu_ring *ring;
 	int i, need_preempt;
@@ -370,7 +370,7 @@ int amdgpu_mcbp_scan(struct amdgpu_ring_mux *mux)
 }
 
 /* Trigger Mid-Command Buffer Preemption (MCBP) and find if we need to resubmit. */
-int amdgpu_mcbp_trigger_preempt(struct amdgpu_ring_mux *mux)
+static int amdgpu_mcbp_trigger_preempt(struct amdgpu_ring_mux *mux)
 {
 	int r;
 
@@ -434,7 +434,7 @@ void amdgpu_ring_mux_start_ib(struct amdgpu_ring_mux *mux, struct amdgpu_ring *r
 
 static void scan_and_remove_signaled_chunk(struct amdgpu_ring_mux *mux, struct amdgpu_ring *ring)
 {
-	uint32_t last_seq, size = 0;
+	uint32_t last_seq = 0;
 	struct amdgpu_mux_entry *e;
 	struct amdgpu_mux_chunk *chunk, *tmp;
 
@@ -450,8 +450,6 @@ static void scan_and_remove_signaled_chunk(struct amdgpu_ring_mux *mux, struct a
 		if (chunk->sync_seq <= last_seq) {
 			list_del(&chunk->entry);
 			kmem_cache_free(amdgpu_mux_chunk_slab, chunk);
-		} else {
-			size++;
 		}
 	}
 }
-- 
2.25.1

Re: [PATCH] drm/amdgpu: Make amdgpu_ring_mux functions as static

[Christian König]

Am 05.12.22 um 03:27 schrieb jiadong.zhu@amd.com:
> From: Jiadong Zhu <Jiadong.Zhu@amd.com>
>
> lkp robot reported missing-prototypes and unused-but-set-variable warnings on
> some functions of amdgpu_mcbp_mux.c. Make them static and remove the unused
> variable.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jiadong Zhu <Jiadong.Zhu@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c
> index 3348337379da..62079f0e3ee8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring_mux.c
> @@ -350,7 +350,7 @@ unsigned int amdgpu_sw_ring_priority(int idx)
>   }
>   
>   /*Scan on low prio rings to have unsignaled fence and high ring has no fence.*/
> -int amdgpu_mcbp_scan(struct amdgpu_ring_mux *mux)
> +static int amdgpu_mcbp_scan(struct amdgpu_ring_mux *mux)
>   {
>   	struct amdgpu_ring *ring;
>   	int i, need_preempt;
> @@ -370,7 +370,7 @@ int amdgpu_mcbp_scan(struct amdgpu_ring_mux *mux)
>   }
>   
>   /* Trigger Mid-Command Buffer Preemption (MCBP) and find if we need to resubmit. */
> -int amdgpu_mcbp_trigger_preempt(struct amdgpu_ring_mux *mux)
> +static int amdgpu_mcbp_trigger_preempt(struct amdgpu_ring_mux *mux)
>   {
>   	int r;
>   
> @@ -434,7 +434,7 @@ void amdgpu_ring_mux_start_ib(struct amdgpu_ring_mux *mux, struct amdgpu_ring *r
>   
>   static void scan_and_remove_signaled_chunk(struct amdgpu_ring_mux *mux, struct amdgpu_ring *ring)
>   {
> -	uint32_t last_seq, size = 0;
> +	uint32_t last_seq = 0;
>   	struct amdgpu_mux_entry *e;
>   	struct amdgpu_mux_chunk *chunk, *tmp;
>   
> @@ -450,8 +450,6 @@ static void scan_and_remove_signaled_chunk(struct amdgpu_ring_mux *mux, struct a
>   		if (chunk->sync_seq <= last_seq) {
>   			list_del(&chunk->entry);
>   			kmem_cache_free(amdgpu_mux_chunk_slab, chunk);
> -		} else {
> -			size++;
>   		}
>   	}
>   }