* [PATCH] drm/amdkfd: set precise mem ops caps to disabled for gfx 11 and 12
@ 2025-03-14 15:14 Jonathan Kim
2025-03-17 11:01 ` Lancelot SIX
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Kim @ 2025-03-14 15:14 UTC (permalink / raw)
To: amd-gfx; +Cc: Lancelot.Six, Jonathan Kim
Clause instructions with precise memory enabled currently hang the
shader so set capabilities flag to disabled since it's unsafe to use
for debugging.
Signed-off-by: Jonathan Kim <jonathan.kim@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 27e7356eed6f..e477d7509646 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -2006,10 +2006,6 @@ static void kfd_topology_set_capabilities(struct kfd_topology_device *dev)
dev->node_props.debug_prop |= HSA_DBG_WATCH_ADDR_MASK_LO_BIT_GFX10 |
HSA_DBG_WATCH_ADDR_MASK_HI_BIT;
- if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(11, 0, 0))
- dev->node_props.capability |=
- HSA_CAP_TRAP_DEBUG_PRECISE_MEMORY_OPERATIONS_SUPPORTED;
-
if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(12, 0, 0))
dev->node_props.capability |=
HSA_CAP_TRAP_DEBUG_PRECISE_ALU_OPERATIONS_SUPPORTED;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdkfd: set precise mem ops caps to disabled for gfx 11 and 12
2025-03-14 15:14 [PATCH] drm/amdkfd: set precise mem ops caps to disabled for gfx 11 and 12 Jonathan Kim
@ 2025-03-17 11:01 ` Lancelot SIX
2025-03-17 20:40 ` Kasiviswanathan, Harish
0 siblings, 1 reply; 3+ messages in thread
From: Lancelot SIX @ 2025-03-17 11:01 UTC (permalink / raw)
To: Jonathan Kim, amd-gfx
On 14/03/2025 15:14, Jonathan Kim wrote:
> Clause instructions with precise memory enabled currently hang the
> shader so set capabilities flag to disabled since it's unsafe to use
> for debugging.
>
> Signed-off-by: Jonathan Kim <jonathan.kim@amd.com>
Hi,
I have tested this for gfx11.
For what it is worth, this patch looks to me.
Tested-by: Lancelot Six <lancelot.six@amd.com>
Best,
Lancelot.
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 27e7356eed6f..e477d7509646 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -2006,10 +2006,6 @@ static void kfd_topology_set_capabilities(struct kfd_topology_device *dev)
> dev->node_props.debug_prop |= HSA_DBG_WATCH_ADDR_MASK_LO_BIT_GFX10 |
> HSA_DBG_WATCH_ADDR_MASK_HI_BIT;
>
> - if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(11, 0, 0))
> - dev->node_props.capability |=
> - HSA_CAP_TRAP_DEBUG_PRECISE_MEMORY_OPERATIONS_SUPPORTED;
> -
> if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(12, 0, 0))
> dev->node_props.capability |=
> HSA_CAP_TRAP_DEBUG_PRECISE_ALU_OPERATIONS_SUPPORTED;
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdkfd: set precise mem ops caps to disabled for gfx 11 and 12
2025-03-17 11:01 ` Lancelot SIX
@ 2025-03-17 20:40 ` Kasiviswanathan, Harish
0 siblings, 0 replies; 3+ messages in thread
From: Kasiviswanathan, Harish @ 2025-03-17 20:40 UTC (permalink / raw)
To: Six, Lancelot, Kim, Jonathan, amd-gfx@lists.freedesktop.org
[Public]
Reviewed-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Lancelot SIX
Sent: Monday, March 17, 2025 7:02 AM
To: Kim, Jonathan <Jonathan.Kim@amd.com>; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdkfd: set precise mem ops caps to disabled for gfx 11 and 12
On 14/03/2025 15:14, Jonathan Kim wrote:
> Clause instructions with precise memory enabled currently hang the
> shader so set capabilities flag to disabled since it's unsafe to use
> for debugging.
>
> Signed-off-by: Jonathan Kim <jonathan.kim@amd.com>
Hi,
I have tested this for gfx11.
For what it is worth, this patch looks to me.
Tested-by: Lancelot Six <lancelot.six@amd.com>
Best,
Lancelot.
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 27e7356eed6f..e477d7509646 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -2006,10 +2006,6 @@ static void kfd_topology_set_capabilities(struct kfd_topology_device *dev)
> dev->node_props.debug_prop |= HSA_DBG_WATCH_ADDR_MASK_LO_BIT_GFX10 |
> HSA_DBG_WATCH_ADDR_MASK_HI_BIT;
>
> - if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(11, 0, 0))
> - dev->node_props.capability |=
> - HSA_CAP_TRAP_DEBUG_PRECISE_MEMORY_OPERATIONS_SUPPORTED;
> -
> if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(12, 0, 0))
> dev->node_props.capability |=
> HSA_CAP_TRAP_DEBUG_PRECISE_ALU_OPERATIONS_SUPPORTED;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-17 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-14 15:14 [PATCH] drm/amdkfd: set precise mem ops caps to disabled for gfx 11 and 12 Jonathan Kim
2025-03-17 11:01 ` Lancelot SIX
2025-03-17 20:40 ` Kasiviswanathan, Harish
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox