From: "Christian König" <christian.koenig@amd.com>
To: Nirmoy Das <nirmoy.aiemd@gmail.com>, amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com, kenny.ho@amd.com,
luben.tuikov@amd.com, nirmoy.das@amd.com
Subject: Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition
Date: Wed, 22 Jan 2020 12:40:39 +0100 [thread overview]
Message-ID: <4100382f-2a65-5959-094f-cb004602c6fb@amd.com> (raw)
In-Reply-To: <20200122093838.17136-1-nirmoy.das@amd.com>
Am 22.01.20 um 10:38 schrieb Nirmoy Das:
> expand sched_list definition for better understanding.
> Also fix a typo atleast -> at least
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/scheduler/sched_entity.c | 2 +-
> include/drm/gpu_scheduler.h | 5 +++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index ec79e8e5ad3c..63bccd201b97 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -45,7 +45,7 @@
> * @guilty: atomic_t set to 1 when a job on this queue
> * is found to be guilty causing a timeout
> *
> - * Note: the sched_list should have atleast one element to schedule
> + * Note: the sched_list should have at least one element to schedule
> * the entity
> *
> * Returns 0 on success or a negative error code on failure.
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index 9e71be129c30..589be851f8a1 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -52,8 +52,9 @@ enum drm_sched_priority {
> * @list: used to append this struct to the list of entities in the
> * runqueue.
> * @rq: runqueue on which this entity is currently scheduled.
> - * @sched_list: a list of drm_gpu_schedulers on which jobs from this entity can
> - * be scheduled
> + * @sched_list: A list of schedulers (drm_gpu_schedulers).
> + * Jobs from this entity can be scheduled on any scheduler
> + * on this list.
> * @num_sched_list: number of drm_gpu_schedulers in the sched_list.
> * @rq_lock: lock to modify the runqueue to which this entity belongs.
> * @job_queue: the list of jobs of this entity.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-01-22 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 9:38 [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition Nirmoy Das
2020-01-22 11:40 ` Christian König [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-20 16:35 Nirmoy Das
2020-01-20 16:43 ` Luben Tuikov
2020-01-21 14:31 ` William Lewis
2020-01-22 9:36 ` Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4100382f-2a65-5959-094f-cb004602c6fb@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=kenny.ho@amd.com \
--cc=luben.tuikov@amd.com \
--cc=nirmoy.aiemd@gmail.com \
--cc=nirmoy.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox