* [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition
@ 2020-01-20 16:35 Nirmoy Das
2020-01-20 16:43 ` Luben Tuikov
2020-01-21 14:31 ` William Lewis
0 siblings, 2 replies; 6+ messages in thread
From: Nirmoy Das @ 2020-01-20 16:35 UTC (permalink / raw)
To: amd-gfx
Cc: alexander.deucher, kenny.ho, luben.tuikov, nirmoy.das,
christian.koenig
expand sched_list definition for better understanding.
Also fix a typo atleast -> at least
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
drivers/gpu/drm/scheduler/sched_entity.c | 2 +-
include/drm/gpu_scheduler.h | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
index ec79e8e5ad3c..63bccd201b97 100644
--- a/drivers/gpu/drm/scheduler/sched_entity.c
+++ b/drivers/gpu/drm/scheduler/sched_entity.c
@@ -45,7 +45,7 @@
* @guilty: atomic_t set to 1 when a job on this queue
* is found to be guilty causing a timeout
*
- * Note: the sched_list should have atleast one element to schedule
+ * Note: the sched_list should have at least one element to schedule
* the entity
*
* Returns 0 on success or a negative error code on failure.
diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
index 9e71be129c30..9ebba61db177 100644
--- a/include/drm/gpu_scheduler.h
+++ b/include/drm/gpu_scheduler.h
@@ -52,8 +52,9 @@ enum drm_sched_priority {
* @list: used to append this struct to the list of entities in the
* runqueue.
* @rq: runqueue on which this entity is currently scheduled.
- * @sched_list: a list of drm_gpu_schedulers on which jobs from this entity can
- * be scheduled
+ * @sched_list: A list of schedulers (drm_gpu_schedulers).
+ * Jobs from this entity, can be scheduled on any scheduler
+ * on this list.
* @num_sched_list: number of drm_gpu_schedulers in the sched_list.
* @rq_lock: lock to modify the runqueue to which this entity belongs.
* @job_queue: the list of jobs of this entity.
--
2.24.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition
2020-01-20 16:35 Nirmoy Das
@ 2020-01-20 16:43 ` Luben Tuikov
2020-01-21 14:31 ` William Lewis
1 sibling, 0 replies; 6+ messages in thread
From: Luben Tuikov @ 2020-01-20 16:43 UTC (permalink / raw)
To: Nirmoy Das, amd-gfx
Cc: alexander.deucher, kenny.ho, nirmoy.das, christian.koenig
That looks excellent--thank you for submitting it.
Hopefully, the documentation would be more accessible
to everyone, so that everyone would contribute.
Regards,
Luben
On 2020-01-20 11:35 a.m., Nirmoy Das wrote:
> expand sched_list definition for better understanding.
> Also fix a typo atleast -> at least
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> ---
> drivers/gpu/drm/scheduler/sched_entity.c | 2 +-
> include/drm/gpu_scheduler.h | 5 +++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index ec79e8e5ad3c..63bccd201b97 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -45,7 +45,7 @@
> * @guilty: atomic_t set to 1 when a job on this queue
> * is found to be guilty causing a timeout
> *
> - * Note: the sched_list should have atleast one element to schedule
> + * Note: the sched_list should have at least one element to schedule
> * the entity
> *
> * Returns 0 on success or a negative error code on failure.
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index 9e71be129c30..9ebba61db177 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -52,8 +52,9 @@ enum drm_sched_priority {
> * @list: used to append this struct to the list of entities in the
> * runqueue.
> * @rq: runqueue on which this entity is currently scheduled.
> - * @sched_list: a list of drm_gpu_schedulers on which jobs from this entity can
> - * be scheduled
> + * @sched_list: A list of schedulers (drm_gpu_schedulers).
> + * Jobs from this entity, can be scheduled on any scheduler
> + * on this list.
> * @num_sched_list: number of drm_gpu_schedulers in the sched_list.
> * @rq_lock: lock to modify the runqueue to which this entity belongs.
> * @job_queue: the list of jobs of this entity.
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition
2020-01-20 16:35 Nirmoy Das
2020-01-20 16:43 ` Luben Tuikov
@ 2020-01-21 14:31 ` William Lewis
2020-01-22 9:36 ` Nirmoy
1 sibling, 1 reply; 6+ messages in thread
From: William Lewis @ 2020-01-21 14:31 UTC (permalink / raw)
To: amd-gfx@lists.freedesktop.org
If we're worrying about spelling and grammar, see one more nitpick inline.
On 1/20/20 10:35 AM, Nirmoy Das wrote:
> expand sched_list definition for better understanding.
> Also fix a typo atleast -> at least
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> ---
> drivers/gpu/drm/scheduler/sched_entity.c | 2 +-
> include/drm/gpu_scheduler.h | 5 +++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index ec79e8e5ad3c..63bccd201b97 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -45,7 +45,7 @@
> * @guilty: atomic_t set to 1 when a job on this queue
> * is found to be guilty causing a timeout
> *
> - * Note: the sched_list should have atleast one element to schedule
> + * Note: the sched_list should have at least one element to schedule
> * the entity
> *
> * Returns 0 on success or a negative error code on failure.
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index 9e71be129c30..9ebba61db177 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -52,8 +52,9 @@ enum drm_sched_priority {
> * @list: used to append this struct to the list of entities in the
> * runqueue.
> * @rq: runqueue on which this entity is currently scheduled.
> - * @sched_list: a list of drm_gpu_schedulers on which jobs from this entity can
> - * be scheduled
> + * @sched_list: A list of schedulers (drm_gpu_schedulers).
> + * Jobs from this entity, can be scheduled on any scheduler
There's no reason to separate the subject from the verb here with a comma.
> + * on this list.
> * @num_sched_list: number of drm_gpu_schedulers in the sched_list.
> * @rq_lock: lock to modify the runqueue to which this entity belongs.
> * @job_queue: the list of jobs of this entity.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition
2020-01-21 14:31 ` William Lewis
@ 2020-01-22 9:36 ` Nirmoy
0 siblings, 0 replies; 6+ messages in thread
From: Nirmoy @ 2020-01-22 9:36 UTC (permalink / raw)
To: amd-gfx
On 1/21/20 3:31 PM, William Lewis wrote:
>
>> + * @sched_list: A list of schedulers (drm_gpu_schedulers).
>> + * Jobs from this entity, can be scheduled on any scheduler
> There's no reason to separate the subject from the verb here with a comma.
Thanks William.
>
>> + * on this list.
>> * @num_sched_list: number of drm_gpu_schedulers in the sched_list.
>> * @rq_lock: lock to modify the runqueue to which this entity belongs.
>> * @job_queue: the list of jobs of this entity.
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cnirmoy.das%40amd.com%7C24185c9d87dd43ce38b008d79e7eaef1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637152139396188784&sdata=VT66q3X3Std9v11mnTJ9ww6FJODJWoo6IGu8iVFevGs%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition
@ 2020-01-22 9:38 Nirmoy Das
2020-01-22 11:40 ` Christian König
0 siblings, 1 reply; 6+ messages in thread
From: Nirmoy Das @ 2020-01-22 9:38 UTC (permalink / raw)
To: amd-gfx
Cc: alexander.deucher, kenny.ho, luben.tuikov, nirmoy.das,
christian.koenig
expand sched_list definition for better understanding.
Also fix a typo atleast -> at least
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
drivers/gpu/drm/scheduler/sched_entity.c | 2 +-
include/drm/gpu_scheduler.h | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
index ec79e8e5ad3c..63bccd201b97 100644
--- a/drivers/gpu/drm/scheduler/sched_entity.c
+++ b/drivers/gpu/drm/scheduler/sched_entity.c
@@ -45,7 +45,7 @@
* @guilty: atomic_t set to 1 when a job on this queue
* is found to be guilty causing a timeout
*
- * Note: the sched_list should have atleast one element to schedule
+ * Note: the sched_list should have at least one element to schedule
* the entity
*
* Returns 0 on success or a negative error code on failure.
diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
index 9e71be129c30..589be851f8a1 100644
--- a/include/drm/gpu_scheduler.h
+++ b/include/drm/gpu_scheduler.h
@@ -52,8 +52,9 @@ enum drm_sched_priority {
* @list: used to append this struct to the list of entities in the
* runqueue.
* @rq: runqueue on which this entity is currently scheduled.
- * @sched_list: a list of drm_gpu_schedulers on which jobs from this entity can
- * be scheduled
+ * @sched_list: A list of schedulers (drm_gpu_schedulers).
+ * Jobs from this entity can be scheduled on any scheduler
+ * on this list.
* @num_sched_list: number of drm_gpu_schedulers in the sched_list.
* @rq_lock: lock to modify the runqueue to which this entity belongs.
* @job_queue: the list of jobs of this entity.
--
2.24.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition
2020-01-22 9:38 [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition Nirmoy Das
@ 2020-01-22 11:40 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2020-01-22 11:40 UTC (permalink / raw)
To: Nirmoy Das, amd-gfx; +Cc: alexander.deucher, kenny.ho, luben.tuikov, nirmoy.das
Am 22.01.20 um 10:38 schrieb Nirmoy Das:
> expand sched_list definition for better understanding.
> Also fix a typo atleast -> at least
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/scheduler/sched_entity.c | 2 +-
> include/drm/gpu_scheduler.h | 5 +++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index ec79e8e5ad3c..63bccd201b97 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -45,7 +45,7 @@
> * @guilty: atomic_t set to 1 when a job on this queue
> * is found to be guilty causing a timeout
> *
> - * Note: the sched_list should have atleast one element to schedule
> + * Note: the sched_list should have at least one element to schedule
> * the entity
> *
> * Returns 0 on success or a negative error code on failure.
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index 9e71be129c30..589be851f8a1 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -52,8 +52,9 @@ enum drm_sched_priority {
> * @list: used to append this struct to the list of entities in the
> * runqueue.
> * @rq: runqueue on which this entity is currently scheduled.
> - * @sched_list: a list of drm_gpu_schedulers on which jobs from this entity can
> - * be scheduled
> + * @sched_list: A list of schedulers (drm_gpu_schedulers).
> + * Jobs from this entity can be scheduled on any scheduler
> + * on this list.
> * @num_sched_list: number of drm_gpu_schedulers in the sched_list.
> * @rq_lock: lock to modify the runqueue to which this entity belongs.
> * @job_queue: the list of jobs of this entity.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-22 11:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-22 9:38 [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition Nirmoy Das
2020-01-22 11:40 ` Christian König
-- strict thread matches above, loose matches on Subject: below --
2020-01-20 16:35 Nirmoy Das
2020-01-20 16:43 ` Luben Tuikov
2020-01-21 14:31 ` William Lewis
2020-01-22 9:36 ` Nirmoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox