AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hamza Mahfooz <hamza.mahfooz@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	"Limonciello, Mario" <mario.limonciello@amd.com>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	stanislav.lisovskiy@intel.com, Fangzhi Zuo <Jerry.Zuo@amd.com>,
	stable@vger.kernel.org, Wayne Lin <Wayne.Lin@amd.com>,
	Guenter Roeck <linux@roeck-us.net>,
	bskeggs@redhat.com
Subject: Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"
Date: Fri, 27 Jan 2023 09:24:10 -0500	[thread overview]
Message-ID: <45686f49-e46a-5e28-70fa-45bf9aa77ee1@amd.com> (raw)
In-Reply-To: <Y9N/wiIL758c3ozv@kroah.com>

Hey Greg,

On 1/27/23 02:39, Greg KH wrote:
> On Fri, Jan 20, 2023 at 11:51:04AM -0600, Limonciello, Mario wrote:
>> On 1/20/2023 11:46, Guenter Roeck wrote:
>>> On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote:
>>>> This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f.
>>>>
>>>> [Why]
>>>> Changes cause regression on amdgpu mst.
>>>> E.g.
>>>> In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload
>>>> one by one and call fill_dc_mst_payload_table_from_drm() to update the HW
>>>> maintained payload table. But previous change tries to go through all the
>>>> payloads in mst_state and update amdpug hw maintained table in once everytime
>>>> driver only tries to add/remove a specific payload stream only. The newly
>>>> design idea conflicts with the implementation in amdgpu nowadays.
>>>>
>>>> [How]
>>>> Revert this patch first. After addressing all regression problems caused by
>>>> this previous patch, will add it back and adjust it.
>>>
>>> Has there been any progress on this revert, or on fixing the underlying
>>> problem ?
>>>
>>> Thanks,
>>> Guenter
>>
>> Hi Guenter,
>>
>> Wayne is OOO for CNY, but let me update you.
>>
>> Harry has sent out this series which is a collection of proper fixes.
>> https://patchwork.freedesktop.org/series/113125/
>>
>> Once that's reviewed and accepted, 4 of them are applicable for 6.1.
> 
> Any hint on when those will be reviewed and accepted?  patchwork doesn't
> show any activity on them, or at least I can't figure it out...

These patches have already made it into amd-staging-drm-next and as of
https://lore.kernel.org/amd-gfx/20230125220153.320248-1-alexander.deucher@amd.com/
they should land in drm-next soon if they haven't already.

> 
> thanks,
> 
> greg k-h

-- 
Hamza


      parent reply	other threads:[~2023-01-27 14:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12  8:50 [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state" Wayne Lin
2023-01-12 17:37 ` Limonciello, Mario
2023-01-12 21:16 ` Lyude Paul
2023-01-13 10:16 ` Jani Nikula
2023-01-13 10:25   ` Daniel Vetter
2023-01-13 16:19     ` Harry Wentland
2023-01-13 19:28     ` Lyude Paul
2023-01-13 19:45       ` Limonciello, Mario
2023-01-20 17:46 ` Guenter Roeck
2023-01-20 17:51   ` Limonciello, Mario
2023-01-20 18:18     ` Guenter Roeck
2023-01-20 18:39       ` Limonciello, Mario
2023-01-20 21:00         ` Guenter Roeck
2023-01-27  7:39     ` Greg KH
2023-01-27  9:15       ` Linux kernel regression tracking (Thorsten Leemhuis)
2023-01-27 15:02         ` Limonciello, Mario
2023-01-29 13:31           ` Greg KH
2023-02-01 19:43             ` Limonciello, Mario
2023-01-27 14:24       ` Hamza Mahfooz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45686f49-e46a-5e28-70fa-45bf9aa77ee1@amd.com \
    --to=hamza.mahfooz@amd.com \
    --cc=Jerry.Zuo@amd.com \
    --cc=Wayne.Lin@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux@roeck-us.net \
    --cc=mario.limonciello@amd.com \
    --cc=stable@vger.kernel.org \
    --cc=stanislav.lisovskiy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox