Re: [PATCH] drm/amdgpu: fix html doc generation warning

["Christian König" <christian.koenig@amd.com>]

Am 02.10.24 um 11:26 schrieb Sunil Khatri:
> Fix the html doc warning due to mix up of the
> forward declaration of struct amdgpu_ip_block.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
>   drivers/gpu/drm/amd/include/amd_shared.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
> index d892273fdb10..f98b3a544477 100644
> --- a/drivers/gpu/drm/amd/include/amd_shared.h
> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
> @@ -28,6 +28,8 @@
>   
>   
>   #define AMD_MAX_USEC_TIMEOUT		1000000  /* 1000 ms */
> +struct amdgpu_ip_block;
> +

Not a most have but probably best to add an empty line between the 
#define and the forward declaration.

Reviewed-by: Christian König <christian.koenig@amd.com> either way.

>   
>   /*
>    * Chip flags
> @@ -375,8 +377,6 @@ enum amd_dpm_forced_level;
>    * making calls to hooks from each IP block. This list is ordered to ensure
>    * that the driver initializes the IP blocks in a safe sequence.
>    */
> -struct amdgpu_ip_block;
> -
>   struct amd_ip_funcs {
>   	char *name;
>   	int (*early_init)(struct amdgpu_ip_block *ip_block);