* [PATCH] drm/amdgpu: fix html doc generation warning
@ 2024-10-02 9:26 Sunil Khatri
2024-10-02 9:32 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Sunil Khatri @ 2024-10-02 9:26 UTC (permalink / raw)
To: Alex Deucher, Christian König, Boyuan Zhang; +Cc: amd-gfx, Sunil Khatri
Fix the html doc warning due to mix up of the
forward declaration of struct amdgpu_ip_block.
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
drivers/gpu/drm/amd/include/amd_shared.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
index d892273fdb10..f98b3a544477 100644
--- a/drivers/gpu/drm/amd/include/amd_shared.h
+++ b/drivers/gpu/drm/amd/include/amd_shared.h
@@ -28,6 +28,8 @@
#define AMD_MAX_USEC_TIMEOUT 1000000 /* 1000 ms */
+struct amdgpu_ip_block;
+
/*
* Chip flags
@@ -375,8 +377,6 @@ enum amd_dpm_forced_level;
* making calls to hooks from each IP block. This list is ordered to ensure
* that the driver initializes the IP blocks in a safe sequence.
*/
-struct amdgpu_ip_block;
-
struct amd_ip_funcs {
char *name;
int (*early_init)(struct amdgpu_ip_block *ip_block);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: fix html doc generation warning
2024-10-02 9:26 [PATCH] drm/amdgpu: fix html doc generation warning Sunil Khatri
@ 2024-10-02 9:32 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2024-10-02 9:32 UTC (permalink / raw)
To: Sunil Khatri, Alex Deucher, Boyuan Zhang; +Cc: amd-gfx
Am 02.10.24 um 11:26 schrieb Sunil Khatri:
> Fix the html doc warning due to mix up of the
> forward declaration of struct amdgpu_ip_block.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
> drivers/gpu/drm/amd/include/amd_shared.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
> index d892273fdb10..f98b3a544477 100644
> --- a/drivers/gpu/drm/amd/include/amd_shared.h
> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
> @@ -28,6 +28,8 @@
>
>
> #define AMD_MAX_USEC_TIMEOUT 1000000 /* 1000 ms */
> +struct amdgpu_ip_block;
> +
Not a most have but probably best to add an empty line between the
#define and the forward declaration.
Reviewed-by: Christian König <christian.koenig@amd.com> either way.
>
> /*
> * Chip flags
> @@ -375,8 +377,6 @@ enum amd_dpm_forced_level;
> * making calls to hooks from each IP block. This list is ordered to ensure
> * that the driver initializes the IP blocks in a safe sequence.
> */
> -struct amdgpu_ip_block;
> -
> struct amd_ip_funcs {
> char *name;
> int (*early_init)(struct amdgpu_ip_block *ip_block);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-02 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-02 9:26 [PATCH] drm/amdgpu: fix html doc generation warning Sunil Khatri
2024-10-02 9:32 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox