From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Asad Kamal <asad.kamal@amd.com>, amd-gfx@lists.freedesktop.org
Cc: le.ma@amd.com, hawking.zhang@amd.com, shiwu.zhang@amd.com,
alexander.deucher@amd.com
Subject: Re: [PATCH v2] drm/amd/pm: Fill ip version for SMU v13.0.12
Date: Mon, 13 Jan 2025 09:58:39 +0530 [thread overview]
Message-ID: <4fc84a82-7b07-449f-a383-eaa6bfc4f04f@amd.com> (raw)
In-Reply-To: <20250111052806.36431-1-asad.kamal@amd.com>
On 1/11/2025 10:58 AM, Asad Kamal wrote:
> Fill ip version in pm_metrics for SMU v13.0.12
>
> v2: Remove ip version check(Lijo)
>
> Signed-off-by: Asad Kamal <asad.kamal@amd.com>
> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 8ab30b2f7119..f358a8abe91e 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -599,10 +599,8 @@ static ssize_t smu_v13_0_6_get_pm_metrics(struct smu_context *smu,
>
> memset(&pm_metrics->common_header, 0,
> sizeof(pm_metrics->common_header));
> - if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 6))
> - pm_metrics->common_header.mp1_ip_discovery_version = IP_VERSION(13, 0, 6);
> - if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 14))
> - pm_metrics->common_header.mp1_ip_discovery_version = IP_VERSION(13, 0, 14);
> + pm_metrics->common_header.mp1_ip_discovery_version =
> + amdgpu_ip_version(smu->adev, MP1_HWIP, 0);
> pm_metrics->common_header.pmfw_version = pmfw_version;
> pm_metrics->common_header.pmmetrics_version = table_version;
> pm_metrics->common_header.structure_size =
prev parent reply other threads:[~2025-01-13 4:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 5:28 [PATCH v2] drm/amd/pm: Fill ip version for SMU v13.0.12 Asad Kamal
2025-01-13 4:28 ` Lazar, Lijo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fc84a82-7b07-449f-a383-eaa6bfc4f04f@amd.com \
--to=lijo.lazar@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=asad.kamal@amd.com \
--cc=hawking.zhang@amd.com \
--cc=le.ma@amd.com \
--cc=shiwu.zhang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).