* [PATCH v2] drm/amd/pm: Fill ip version for SMU v13.0.12
@ 2025-01-11 5:28 Asad Kamal
2025-01-13 4:28 ` Lazar, Lijo
0 siblings, 1 reply; 2+ messages in thread
From: Asad Kamal @ 2025-01-11 5:28 UTC (permalink / raw)
To: amd-gfx, lijo.lazar
Cc: le.ma, hawking.zhang, shiwu.zhang, Asad.Kamal, alexander.deucher,
Hawking Zhang
Fill ip version in pm_metrics for SMU v13.0.12
v2: Remove ip version check(Lijo)
Signed-off-by: Asad Kamal <asad.kamal@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index 8ab30b2f7119..f358a8abe91e 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -599,10 +599,8 @@ static ssize_t smu_v13_0_6_get_pm_metrics(struct smu_context *smu,
memset(&pm_metrics->common_header, 0,
sizeof(pm_metrics->common_header));
- if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 6))
- pm_metrics->common_header.mp1_ip_discovery_version = IP_VERSION(13, 0, 6);
- if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 14))
- pm_metrics->common_header.mp1_ip_discovery_version = IP_VERSION(13, 0, 14);
+ pm_metrics->common_header.mp1_ip_discovery_version =
+ amdgpu_ip_version(smu->adev, MP1_HWIP, 0);
pm_metrics->common_header.pmfw_version = pmfw_version;
pm_metrics->common_header.pmmetrics_version = table_version;
pm_metrics->common_header.structure_size =
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/amd/pm: Fill ip version for SMU v13.0.12
2025-01-11 5:28 [PATCH v2] drm/amd/pm: Fill ip version for SMU v13.0.12 Asad Kamal
@ 2025-01-13 4:28 ` Lazar, Lijo
0 siblings, 0 replies; 2+ messages in thread
From: Lazar, Lijo @ 2025-01-13 4:28 UTC (permalink / raw)
To: Asad Kamal, amd-gfx; +Cc: le.ma, hawking.zhang, shiwu.zhang, alexander.deucher
On 1/11/2025 10:58 AM, Asad Kamal wrote:
> Fill ip version in pm_metrics for SMU v13.0.12
>
> v2: Remove ip version check(Lijo)
>
> Signed-off-by: Asad Kamal <asad.kamal@amd.com>
> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 8ab30b2f7119..f358a8abe91e 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -599,10 +599,8 @@ static ssize_t smu_v13_0_6_get_pm_metrics(struct smu_context *smu,
>
> memset(&pm_metrics->common_header, 0,
> sizeof(pm_metrics->common_header));
> - if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 6))
> - pm_metrics->common_header.mp1_ip_discovery_version = IP_VERSION(13, 0, 6);
> - if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 14))
> - pm_metrics->common_header.mp1_ip_discovery_version = IP_VERSION(13, 0, 14);
> + pm_metrics->common_header.mp1_ip_discovery_version =
> + amdgpu_ip_version(smu->adev, MP1_HWIP, 0);
> pm_metrics->common_header.pmfw_version = pmfw_version;
> pm_metrics->common_header.pmmetrics_version = table_version;
> pm_metrics->common_header.structure_size =
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-13 4:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-11 5:28 [PATCH v2] drm/amd/pm: Fill ip version for SMU v13.0.12 Asad Kamal
2025-01-13 4:28 ` Lazar, Lijo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox