From: Leo Li <sunpeng.li-5C7GfCeVMHo@public.gmane.org>
To: "Deucher,
Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
"Wentland, Harry" <Harry.Wentland-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH 32/32] drm/amd/display: Fix dim display on DCE11
Date: Fri, 6 Apr 2018 16:18:59 -0400 [thread overview]
Message-ID: <52d6f446-a044-40a2-840b-169cd61ea1da@amd.com> (raw)
In-Reply-To: <BN6PR12MB18095513D4EAE9751423B742F7A40-/b2+HYfkarSEx6ez0IUAagdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On 2018-04-04 11:17 AM, Deucher, Alexander wrote:
> Do other DCE blocks need this fix as well? Or is this code shared with
> say DCE8 and DCE10?
Yes, it's all shared. The hook for this is initialized in
dce110_hw_sequencer_construct(), which is called for all DCE.
Leo
>
>
> Alex
>
> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of
> Harry Wentland <harry.wentland@amd.com>
> *Sent:* Tuesday, April 3, 2018 9:27 PM
> *To:* amd-gfx@lists.freedesktop.org
> *Cc:* Li, Sun peng (Leo)
> *Subject:* [PATCH 32/32] drm/amd/display: Fix dim display on DCE11
> From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>
>
> Before programming the input gamma, check that we're not using the
> identity correction.
>
> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
> Reviewed-by: Anthony Koo <Anthony.Koo@amd.com>
> Acked-by: Harry Wentland <harry.wentland@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index 99d192200797..f385b18d5c2e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -280,7 +280,9 @@ dce110_set_input_transfer_func(struct pipe_ctx
> *pipe_ctx,
> build_prescale_params(&prescale_params, plane_state);
> ipp->funcs->ipp_program_prescale(ipp, &prescale_params);
>
> - if (plane_state->gamma_correction &&
> dce_use_lut(plane_state->format))
> + if (plane_state->gamma_correction &&
> + !plane_state->gamma_correction->is_identity &&
> + dce_use_lut(plane_state->format))
> ipp->funcs->ipp_program_input_lut(ipp,
> plane_state->gamma_correction);
>
> if (tf == NULL) {
> --
> 2.15.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-04-06 20:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 1:27 [PATCH 00/32] DC Patches Apr 3, 2018 Harry Wentland
[not found] ` <20180404012747.5651-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-04-04 1:27 ` [PATCH 01/32] drm/amd/display: Only register backlight device if embedded panel connected Harry Wentland
2018-04-04 1:27 ` [PATCH 02/32] drm/amd/display: Don't register backlight on connector_destroy Harry Wentland
2018-04-04 1:27 ` [PATCH 03/32] drm/amd/display: Program v_total_min/max after v_total_cntl Harry Wentland
2018-04-04 1:27 ` [PATCH 04/32] drm/amd/display: Set ignore_msa_timing_param Harry Wentland
2018-04-04 1:27 ` [PATCH 05/32] drm/amd/display: Non-HDMI DP active dongle should not support YUV pixel format Harry Wentland
2018-04-04 1:27 ` [PATCH 06/32] drm/amd/display: Fix potential access beyond end of array in CM Harry Wentland
2018-04-04 1:27 ` [PATCH 07/32] drm/amd/display: Add Dynamic debug prints Harry Wentland
2018-04-04 1:27 ` [PATCH 08/32] drm/amd/display: Add vmax/min_sel prints to dcn10_log_hw_state Harry Wentland
2018-04-04 1:27 ` [PATCH 09/32] drm/amd/display: Implement dm_get_timestamp Harry Wentland
2018-04-04 1:27 ` [PATCH 10/32] drm/amd/display: add delay between panel pwr off to on Harry Wentland
2018-04-04 1:27 ` [PATCH 11/32] drm/amd/display: Set all update flags when we have full update Harry Wentland
2018-04-04 1:27 ` [PATCH 12/32] drm/amd/display: Refactor FreeSync module Harry Wentland
2018-04-04 1:27 ` [PATCH 13/32] drm/amd/display: Refactor stream encoder for HW review Harry Wentland
2018-04-04 1:27 ` [PATCH 14/32] drm/amd/display: remove unused enum Harry Wentland
2018-04-04 1:27 ` [PATCH 15/32] drm/amd/display: fix link bw calculation for 422 and 420 encoding Harry Wentland
2018-04-04 1:27 ` [PATCH 16/32] drm/amd/display: Fill calcs date from stream src/dst if available Harry Wentland
2018-04-04 1:27 ` [PATCH 17/32] drm/amd/display: Change disable backlight ramp change threshold from 0 to maximum value Harry Wentland
2018-04-04 1:27 ` [PATCH 18/32] drm/amd/display: Update scaler v_active data if interlaced Harry Wentland
2018-04-04 1:27 ` [PATCH 19/32] drm/amd/display: Make DCN stream encoder shareable Harry Wentland
2018-04-04 1:27 ` [PATCH 20/32] drm/amd/display: csc updates require FULL update Harry Wentland
2018-04-04 1:27 ` [PATCH 21/32] drm/amd/display: Fix FBC text console corruption Harry Wentland
2018-04-04 1:27 ` [PATCH 22/32] drm/amd/display: dal 3.1.41 Harry Wentland
2018-04-04 1:27 ` [PATCH 23/32] drm/amd/display: Updated HDR Static Metadata to directly take info packet raw Harry Wentland
2018-04-04 1:27 ` [PATCH 24/32] drm/amd/display: Get rid of unused input_tf Harry Wentland
2018-04-04 1:27 ` [PATCH 25/32] drm/amd/display: Remove unused fields Harry Wentland
2018-04-04 1:27 ` [PATCH 26/32] drm/amd/display: Do not use os types Harry Wentland
2018-04-04 1:27 ` [PATCH 27/32] drm/amd/display: csc_transform to dc_csc_transform Harry Wentland
2018-04-04 1:27 ` [PATCH 28/32] drm/amd/display: Refactor color module Harry Wentland
2018-04-04 1:27 ` [PATCH 29/32] drm/amd/display: move color_transfer_func to color mod Harry Wentland
2018-04-04 1:27 ` [PATCH 30/32] drm/amd/display: Fix structure initialization of hdmi_info_packet Harry Wentland
2018-04-04 1:27 ` [PATCH 31/32] drm/amd/display: Have DC manage its own allocation of gamma Harry Wentland
2018-04-04 1:27 ` [PATCH 32/32] drm/amd/display: Fix dim display on DCE11 Harry Wentland
[not found] ` <20180404012747.5651-33-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-04-04 7:18 ` Michel Dänzer
2018-04-04 15:17 ` Deucher, Alexander
[not found] ` <BN6PR12MB18095513D4EAE9751423B742F7A40-/b2+HYfkarSEx6ez0IUAagdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-04-06 20:18 ` Leo Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52d6f446-a044-40a2-840b-169cd61ea1da@amd.com \
--to=sunpeng.li-5c7gfcevmho@public.gmane.org \
--cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
--cc=Harry.Wentland-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox