From: Leo <sunpeng.li@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>,
Chandan Vurdigere Nataraj <chandan.vurdigerenataraj@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Harry Wentland <harry.wentland@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/display : Log DP link training failure reason
Date: Thu, 23 Jun 2022 16:33:56 -0400 [thread overview]
Message-ID: <563f4430-c36b-139d-bcfe-902168e7a2bc@amd.com> (raw)
In-Reply-To: <CADnq5_P7DPv+HXrUUdC_KxG8LmAdRyKH-5vZZcL2GdRYZUzVfQ@mail.gmail.com>
On 2022-06-23 12:48, Alex Deucher wrote:
> On Thu, Jun 23, 2022 at 3:33 AM Chandan Vurdigere Nataraj
> <chandan.vurdigerenataraj@amd.com> wrote:
>>
>> [Why]
>> Existing logs doesn't print DP LT failure reason
>>
>> [How]
>> Update the existing log with DP LT failure reason
>>
>> Signed-off-by: Chandan Vurdigere Nataraj <chandan.vurdigerenataraj@amd.com>
>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Leo Li <sunpeng.li@amd.com>
>
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
>> index 4027f439a5a4..c8355acd3672 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
>> @@ -2786,9 +2786,9 @@ bool perform_link_training_with_retries(
>> break;
>> }
>>
>> - DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d)\n",
>> + DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) : fail reason:(%d)\n",
>> __func__, link->link_index, (unsigned int)j + 1, attempts, cur_link_settings.link_rate,
>> - cur_link_settings.lane_count);
>> + cur_link_settings.lane_count, status);
>>
>> dp_disable_link_phy(link, &pipe_ctx->link_res, signal);
>>
>> --
>> 2.25.1
>>
prev parent reply other threads:[~2022-06-23 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 7:33 [PATCH] drm/amd/display : Log DP link training failure reason Chandan Vurdigere Nataraj
2022-06-23 16:48 ` Alex Deucher
2022-06-23 20:33 ` Leo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563f4430-c36b-139d-bcfe-902168e7a2bc@amd.com \
--to=sunpeng.li@amd.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chandan.vurdigerenataraj@amd.com \
--cc=harry.wentland@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox