* [PATCH] drm/amd/display : Log DP link training failure reason
@ 2022-06-23 7:33 Chandan Vurdigere Nataraj
2022-06-23 16:48 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Chandan Vurdigere Nataraj @ 2022-06-23 7:33 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher; +Cc: amd-gfx
[Why]
Existing logs doesn't print DP LT failure reason
[How]
Update the existing log with DP LT failure reason
Signed-off-by: Chandan Vurdigere Nataraj <chandan.vurdigerenataraj@amd.com>
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 4027f439a5a4..c8355acd3672 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -2786,9 +2786,9 @@ bool perform_link_training_with_retries(
break;
}
- DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d)\n",
+ DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) : fail reason:(%d)\n",
__func__, link->link_index, (unsigned int)j + 1, attempts, cur_link_settings.link_rate,
- cur_link_settings.lane_count);
+ cur_link_settings.lane_count, status);
dp_disable_link_phy(link, &pipe_ctx->link_res, signal);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display : Log DP link training failure reason
2022-06-23 7:33 [PATCH] drm/amd/display : Log DP link training failure reason Chandan Vurdigere Nataraj
@ 2022-06-23 16:48 ` Alex Deucher
2022-06-23 20:33 ` Leo
0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2022-06-23 16:48 UTC (permalink / raw)
To: Chandan Vurdigere Nataraj
Cc: Leo Li, Alex Deucher, Harry Wentland, amd-gfx list
On Thu, Jun 23, 2022 at 3:33 AM Chandan Vurdigere Nataraj
<chandan.vurdigerenataraj@amd.com> wrote:
>
> [Why]
> Existing logs doesn't print DP LT failure reason
>
> [How]
> Update the existing log with DP LT failure reason
>
> Signed-off-by: Chandan Vurdigere Nataraj <chandan.vurdigerenataraj@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 4027f439a5a4..c8355acd3672 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -2786,9 +2786,9 @@ bool perform_link_training_with_retries(
> break;
> }
>
> - DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d)\n",
> + DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) : fail reason:(%d)\n",
> __func__, link->link_index, (unsigned int)j + 1, attempts, cur_link_settings.link_rate,
> - cur_link_settings.lane_count);
> + cur_link_settings.lane_count, status);
>
> dp_disable_link_phy(link, &pipe_ctx->link_res, signal);
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display : Log DP link training failure reason
2022-06-23 16:48 ` Alex Deucher
@ 2022-06-23 20:33 ` Leo
0 siblings, 0 replies; 3+ messages in thread
From: Leo @ 2022-06-23 20:33 UTC (permalink / raw)
To: Alex Deucher, Chandan Vurdigere Nataraj
Cc: Alex Deucher, Harry Wentland, amd-gfx list
On 2022-06-23 12:48, Alex Deucher wrote:
> On Thu, Jun 23, 2022 at 3:33 AM Chandan Vurdigere Nataraj
> <chandan.vurdigerenataraj@amd.com> wrote:
>>
>> [Why]
>> Existing logs doesn't print DP LT failure reason
>>
>> [How]
>> Update the existing log with DP LT failure reason
>>
>> Signed-off-by: Chandan Vurdigere Nataraj <chandan.vurdigerenataraj@amd.com>
>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Leo Li <sunpeng.li@amd.com>
>
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
>> index 4027f439a5a4..c8355acd3672 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
>> @@ -2786,9 +2786,9 @@ bool perform_link_training_with_retries(
>> break;
>> }
>>
>> - DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d)\n",
>> + DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ rate(%d) x lane(%d) : fail reason:(%d)\n",
>> __func__, link->link_index, (unsigned int)j + 1, attempts, cur_link_settings.link_rate,
>> - cur_link_settings.lane_count);
>> + cur_link_settings.lane_count, status);
>>
>> dp_disable_link_phy(link, &pipe_ctx->link_res, signal);
>>
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-23 20:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-23 7:33 [PATCH] drm/amd/display : Log DP link training failure reason Chandan Vurdigere Nataraj
2022-06-23 16:48 ` Alex Deucher
2022-06-23 20:33 ` Leo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox