* Re: [PATCH] drm: amd: Use kmemdup instead of duplicating its function
[not found] <1537284932-62278-1-git-send-email-zhongjiang@huawei.com>
@ 2018-09-21 14:13 ` zhong jiang
0 siblings, 0 replies; only message in thread
From: zhong jiang @ 2018-09-21 14:13 UTC (permalink / raw)
To: airlied, alexander.deucher
Cc: oded.gabbay, christian.koenig, David1.Zhou, dri-devel,
linux-kernel, amd-gfx, Harry Wentland
+cc amd-gfx@lists.freedesktop.org
Thanks,
zhong jiang
On 2018/9/18 23:35, zhong jiang wrote:
> kmemdup has implemented the function that kmalloc() + memcpy().
> We prefer to kmemdup rather than code opened implementation.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index ee49960..8ddd585 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -747,12 +747,10 @@ int kfd_create_crat_image_acpi(void **crat_image, size_t *size)
> return -ENODATA;
> }
>
> - pcrat_image = kmalloc(crat_table->length, GFP_KERNEL);
> + pcrat_image = kmemdup(crat_table, crat_table->length, GFP_KERNEL);
> if (!pcrat_image)
> return -ENOMEM;
>
> - memcpy(pcrat_image, crat_table, crat_table->length);
> -
> *crat_image = pcrat_image;
> *size = crat_table->length;
>
^ permalink raw reply [flat|nested] only message in thread