Re: [PATCH] drm/amdgpu: Avoid null pointer dereference in soc15_reg_base_init()

* Re: [PATCH] drm/amdgpu: Avoid null pointer dereference in soc15_reg_base_init()
@ 2020-10-01 13:30 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-10-01 13:30 UTC (permalink / raw)
  To: Dirk Gouders, amd-gfx
  Cc: David Airlie, kernel-janitors, linux-kernel, dri-devel,
	Wenhui Sheng, Daniel Vetter, Alex Deucher, Evan Quan,
	Christian König, Hawking Zhang

> that change, the NULL pointer dereference does not occur:

* Please provide a proper tag “Signed-off-by”.

* How do you think about to add the tag “Fixes” to the commit message?

* Would another imperative wording become helpful for the change description?

* Would you like to choose an other patch subject?

…
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -699,7 +699,8 @@  static void soc15_reg_base_init(struct amdgpu_device *adev)
>                                          "fallback to legacy init method\n");
>                                 vega10_reg_base_init(adev);
>                         }
> -               }
> +               } else
> +                       vega10_reg_base_init(adev);
>                 break;
…

Will curly brackets be relevant also for this else branch?

Regards,
Markus
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] only message in thread