Re: [PATCH 3/8] drm/amdgpu: add pre_asic_init callback for SI

From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH 3/8] drm/amdgpu: add pre_asic_init callback for SI
Date: Fri, 28 Aug 2020 10:06:10 +0200	[thread overview]
Message-ID: <62c44d4c-ece3-5e61-7d20-2d8da9734a1a@gmail.com> (raw)
In-Reply-To: <20200824161527.2001591-3-alexander.deucher@amd.com>

Am 24.08.20 um 18:15 schrieb Alex Deucher:
> Nothing to do for this family.

Uff, no. Can't we just make the callback optional?

>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/si.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
> index eaa2f071b139..455d5e366c69 100644
> --- a/drivers/gpu/drm/amd/amdgpu/si.c
> +++ b/drivers/gpu/drm/amd/amdgpu/si.c
> @@ -1871,6 +1871,10 @@ static int si_set_vce_clocks(struct amdgpu_device *adev, u32 evclk, u32 ecclk)
>   	return 0;
>   }
>   
> +static void si_pre_asic_init(struct amdgpu_device *adev)
> +{
> +}
> +
>   static const struct amdgpu_asic_funcs si_asic_funcs =
>   {
>   	.read_disabled_bios = &si_read_disabled_bios,
> @@ -1892,6 +1896,7 @@ static const struct amdgpu_asic_funcs si_asic_funcs =
>   	.need_reset_on_init = &si_need_reset_on_init,
>   	.get_pcie_replay_count = &si_get_pcie_replay_count,
>   	.supports_baco = &si_asic_supports_baco,
> +	.pre_asic_init = &si_pre_asic_init,
>   };
>   
>   static uint32_t si_get_rev_id(struct amdgpu_device *adev)

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx