[PATCH] drm/amdgpu: remove unused parameter in amdgpu_vmid_grab_idle

[PATCH] drm/amdgpu: remove unused parameter in amdgpu_vmid_grab_idle

[Yifan Zhang]

amdgpu_vm is not used in amdgpu_vmid_grab_idle.

Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
index ff1ea99292fb..ddd0891da116 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
@@ -188,7 +188,6 @@ static bool amdgpu_vmid_compatible(struct amdgpu_vmid *id,
 /**
  * amdgpu_vmid_grab_idle - grab idle VMID
  *
- * @vm: vm to allocate id for
  * @ring: ring we want to submit job to
  * @idle: resulting idle VMID
  * @fence: fence to wait for if no id could be grabbed
@@ -196,8 +195,7 @@ static bool amdgpu_vmid_compatible(struct amdgpu_vmid *id,
  * Try to find an idle VMID, if none is idle add a fence to wait to the sync
  * object. Returns -ENOMEM when we are out of memory.
  */
-static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,
-				 struct amdgpu_ring *ring,
+static int amdgpu_vmid_grab_idle(struct amdgpu_ring *ring,
 				 struct amdgpu_vmid **idle,
 				 struct dma_fence **fence)
 {
@@ -405,7 +403,7 @@ int amdgpu_vmid_grab(struct amdgpu_vm *vm, struct amdgpu_ring *ring,
 	int r = 0;
 
 	mutex_lock(&id_mgr->lock);
-	r = amdgpu_vmid_grab_idle(vm, ring, &idle, fence);
+	r = amdgpu_vmid_grab_idle(ring, &idle, fence);
 	if (r || !idle)
 		goto error;
 
-- 
2.37.3

Re: [PATCH] drm/amdgpu: remove unused parameter in amdgpu_vmid_grab_idle

[Christian König]

Am 17.08.23 um 09:00 schrieb Yifan Zhang:
> amdgpu_vm is not used in amdgpu_vmid_grab_idle.
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>

Sorry for the delay, Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> index ff1ea99292fb..ddd0891da116 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> @@ -188,7 +188,6 @@ static bool amdgpu_vmid_compatible(struct amdgpu_vmid *id,
>   /**
>    * amdgpu_vmid_grab_idle - grab idle VMID
>    *
> - * @vm: vm to allocate id for
>    * @ring: ring we want to submit job to
>    * @idle: resulting idle VMID
>    * @fence: fence to wait for if no id could be grabbed
> @@ -196,8 +195,7 @@ static bool amdgpu_vmid_compatible(struct amdgpu_vmid *id,
>    * Try to find an idle VMID, if none is idle add a fence to wait to the sync
>    * object. Returns -ENOMEM when we are out of memory.
>    */
> -static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,
> -				 struct amdgpu_ring *ring,
> +static int amdgpu_vmid_grab_idle(struct amdgpu_ring *ring,
>   				 struct amdgpu_vmid **idle,
>   				 struct dma_fence **fence)
>   {
> @@ -405,7 +403,7 @@ int amdgpu_vmid_grab(struct amdgpu_vm *vm, struct amdgpu_ring *ring,
>   	int r = 0;
>   
>   	mutex_lock(&id_mgr->lock);
> -	r = amdgpu_vmid_grab_idle(vm, ring, &idle, fence);
> +	r = amdgpu_vmid_grab_idle(ring, &idle, fence);
>   	if (r || !idle)
>   		goto error;
>