AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] amdkfd: Do nto wait for queue op response during reset
@ 2025-11-04 17:33 Ahmad Rehman
  2025-11-04 18:06 ` Lazar, Lijo
  2025-11-05  9:36 ` Michel Dänzer
  0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Rehman @ 2025-11-04 17:33 UTC (permalink / raw)
  To: amd-gfx; +Cc: Lijo.Lazar, Ahmad Rehman

This patch adds the condition to not wait for
the queue response for unmap, if the gpu is in reset.

Signed-off-by: Ahmad Rehman <Ahmad.Rehman@amd.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index 4fbe865ff279..0904c36192c7 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -2094,7 +2094,8 @@ int amdkfd_fence_wait_timeout(struct device_queue_manager *dqm,
 
 	while (*fence_addr != fence_value) {
 		/* Fatal err detected, this response won't come */
-		if (amdgpu_amdkfd_is_fed(dqm->dev->adev))
+		if (amdgpu_amdkfd_is_fed(dqm->dev->adev) ||
+				amdgpu_in_reset(dqm->dev->adev))
 			return -EIO;
 
 		if (time_after(jiffies, end_jiffies)) {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] amdkfd: Do nto wait for queue op response during reset
  2025-11-04 17:33 [PATCH] amdkfd: Do nto wait for queue op response during reset Ahmad Rehman
@ 2025-11-04 18:06 ` Lazar, Lijo
  2025-11-05  9:36 ` Michel Dänzer
  1 sibling, 0 replies; 3+ messages in thread
From: Lazar, Lijo @ 2025-11-04 18:06 UTC (permalink / raw)
  To: Ahmad Rehman, amd-gfx



On 11/4/2025 11:03 PM, Ahmad Rehman wrote:
> This patch adds the condition to not wait for
> the queue response for unmap, if the gpu is in reset.
> 
> Signed-off-by: Ahmad Rehman <Ahmad.Rehman@amd.com>

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 4fbe865ff279..0904c36192c7 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -2094,7 +2094,8 @@ int amdkfd_fence_wait_timeout(struct device_queue_manager *dqm,
>   
>   	while (*fence_addr != fence_value) {
>   		/* Fatal err detected, this response won't come */
> -		if (amdgpu_amdkfd_is_fed(dqm->dev->adev))
> +		if (amdgpu_amdkfd_is_fed(dqm->dev->adev) ||
> +				amdgpu_in_reset(dqm->dev->adev))
>   			return -EIO;
>   
>   		if (time_after(jiffies, end_jiffies)) {


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] amdkfd: Do nto wait for queue op response during reset
  2025-11-04 17:33 [PATCH] amdkfd: Do nto wait for queue op response during reset Ahmad Rehman
  2025-11-04 18:06 ` Lazar, Lijo
@ 2025-11-05  9:36 ` Michel Dänzer
  1 sibling, 0 replies; 3+ messages in thread
From: Michel Dänzer @ 2025-11-05  9:36 UTC (permalink / raw)
  To: Ahmad Rehman; +Cc: Lijo.Lazar, amd-gfx

On 11/4/25 18:33, Ahmad Rehman wrote:
> This patch adds the condition to not wait for
> the queue response for unmap, if the gpu is in reset.
> 
> Signed-off-by: Ahmad Rehman <Ahmad.Rehman@amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 4fbe865ff279..0904c36192c7 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -2094,7 +2094,8 @@ int amdkfd_fence_wait_timeout(struct device_queue_manager *dqm,
>  
>  	while (*fence_addr != fence_value) {
>  		/* Fatal err detected, this response won't come */
> -		if (amdgpu_amdkfd_is_fed(dqm->dev->adev))
> +		if (amdgpu_amdkfd_is_fed(dqm->dev->adev) ||
> +				amdgpu_in_reset(dqm->dev->adev))
>  			return -EIO;
>  
>  		if (time_after(jiffies, end_jiffies)) {

Indentation of the second new line looks wrong, should be aligned to the opening parenthesis.


-- 
Earthling Michel Dänzer       \        GNOME / Xwayland / Mesa developer
https://redhat.com             \               Libre software enthusiast

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-05  9:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 17:33 [PATCH] amdkfd: Do nto wait for queue op response during reset Ahmad Rehman
2025-11-04 18:06 ` Lazar, Lijo
2025-11-05  9:36 ` Michel Dänzer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox