[PATCH] drm/amdgpu: cleanup unused variable

[PATCH] drm/amdgpu: cleanup unused variable

[Shashank Sharma]

This patch removes an unused input variable in the MES
doorbell function.

Cc: Christian König <Christian.Koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Shashank Sharma <shashank.sharma@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
index 89ac50405e25..7615daf89ba5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
@@ -40,7 +40,6 @@ int amdgpu_mes_doorbell_process_slice(struct amdgpu_device *adev)
 }
 
 static int amdgpu_mes_kernel_doorbell_get(struct amdgpu_device *adev,
-					 struct amdgpu_mes_process *process,
 					 int ip_type, uint64_t *doorbell_index)
 {
 	unsigned int offset, found;
@@ -65,7 +64,6 @@ static int amdgpu_mes_kernel_doorbell_get(struct amdgpu_device *adev,
 }
 
 static void amdgpu_mes_kernel_doorbell_free(struct amdgpu_device *adev,
-					   struct amdgpu_mes_process *process,
 					   uint32_t doorbell_index)
 {
 	unsigned int old, rel_index;
@@ -623,7 +621,7 @@ int amdgpu_mes_add_hw_queue(struct amdgpu_device *adev, int gang_id,
 	*queue_id = queue->queue_id = r;
 
 	/* allocate a doorbell index for the queue */
-	r = amdgpu_mes_kernel_doorbell_get(adev, gang->process,
+	r = amdgpu_mes_kernel_doorbell_get(adev,
 					  qprops->queue_type,
 					  &qprops->doorbell_off);
 	if (r)
@@ -681,8 +679,7 @@ int amdgpu_mes_add_hw_queue(struct amdgpu_device *adev, int gang_id,
 	return 0;
 
 clean_up_doorbell:
-	amdgpu_mes_kernel_doorbell_free(adev, gang->process,
-				       qprops->doorbell_off);
+	amdgpu_mes_kernel_doorbell_free(adev, qprops->doorbell_off);
 clean_up_queue_id:
 	spin_lock_irqsave(&adev->mes.queue_id_lock, flags);
 	idr_remove(&adev->mes.queue_id_idr, queue->queue_id);
@@ -736,8 +733,7 @@ int amdgpu_mes_remove_hw_queue(struct amdgpu_device *adev, int queue_id)
 			  queue_id);
 
 	list_del(&queue->list);
-	amdgpu_mes_kernel_doorbell_free(adev, gang->process,
-				       queue->doorbell_off);
+	amdgpu_mes_kernel_doorbell_free(adev, queue->doorbell_off);
 	amdgpu_mes_unlock(&adev->mes);
 
 	amdgpu_mes_queue_free_mqd(queue);
-- 
2.43.2

Re: [PATCH] drm/amdgpu: cleanup unused variable

[Christian König]

Am 12.03.24 um 16:31 schrieb Shashank Sharma:
> This patch removes an unused input variable in the MES
> doorbell function.
>
> Cc: Christian König <Christian.Koenig@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Shashank Sharma <shashank.sharma@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> index 89ac50405e25..7615daf89ba5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> @@ -40,7 +40,6 @@ int amdgpu_mes_doorbell_process_slice(struct amdgpu_device *adev)
>   }
>   
>   static int amdgpu_mes_kernel_doorbell_get(struct amdgpu_device *adev,
> -					 struct amdgpu_mes_process *process,
>   					 int ip_type, uint64_t *doorbell_index)
>   {
>   	unsigned int offset, found;
> @@ -65,7 +64,6 @@ static int amdgpu_mes_kernel_doorbell_get(struct amdgpu_device *adev,
>   }
>   
>   static void amdgpu_mes_kernel_doorbell_free(struct amdgpu_device *adev,
> -					   struct amdgpu_mes_process *process,
>   					   uint32_t doorbell_index)
>   {
>   	unsigned int old, rel_index;
> @@ -623,7 +621,7 @@ int amdgpu_mes_add_hw_queue(struct amdgpu_device *adev, int gang_id,
>   	*queue_id = queue->queue_id = r;
>   
>   	/* allocate a doorbell index for the queue */
> -	r = amdgpu_mes_kernel_doorbell_get(adev, gang->process,
> +	r = amdgpu_mes_kernel_doorbell_get(adev,
>   					  qprops->queue_type,
>   					  &qprops->doorbell_off);
>   	if (r)
> @@ -681,8 +679,7 @@ int amdgpu_mes_add_hw_queue(struct amdgpu_device *adev, int gang_id,
>   	return 0;
>   
>   clean_up_doorbell:
> -	amdgpu_mes_kernel_doorbell_free(adev, gang->process,
> -				       qprops->doorbell_off);
> +	amdgpu_mes_kernel_doorbell_free(adev, qprops->doorbell_off);
>   clean_up_queue_id:
>   	spin_lock_irqsave(&adev->mes.queue_id_lock, flags);
>   	idr_remove(&adev->mes.queue_id_idr, queue->queue_id);
> @@ -736,8 +733,7 @@ int amdgpu_mes_remove_hw_queue(struct amdgpu_device *adev, int queue_id)
>   			  queue_id);
>   
>   	list_del(&queue->list);
> -	amdgpu_mes_kernel_doorbell_free(adev, gang->process,
> -				       queue->doorbell_off);
> +	amdgpu_mes_kernel_doorbell_free(adev, queue->doorbell_off);
>   	amdgpu_mes_unlock(&adev->mes);
>   
>   	amdgpu_mes_queue_free_mqd(queue);