* [PATCH] drm/amdkfd: select CONFIG_CRC16
@ 2024-05-28 11:50 Arnd Bergmann
2024-05-28 12:40 ` Lazar, Lijo
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-05-28 11:50 UTC (permalink / raw)
To: Felix Kuehling
Cc: Arnd Bergmann, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Harish Kasiviswanathan, Lijo Lazar,
amd-gfx, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The amdkfd support fails to link when CONFIG_CRC16 is disabled:
aarch64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_topology.o: in function `kfd_topology_add_device':
kfd_topology.c:(.text+0x3a4c): undefined reference to `crc16'
This is a library module that needs to be selected from every user.
Fixes: 3ed181b8ff43 ("drm/amdkfd: Ensure gpu_id is unique")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
index d3c3d3ab7225..f82595af34bf 100644
--- a/drivers/gpu/drm/amd/amdkfd/Kconfig
+++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
@@ -6,6 +6,7 @@
config HSA_AMD
bool "HSA kernel driver for AMD GPU devices"
depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64)
+ select CRC16
select HMM_MIRROR
select MMU_NOTIFIER
select DRM_AMDGPU_USERPTR
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amdkfd: select CONFIG_CRC16
2024-05-28 11:50 [PATCH] drm/amdkfd: select CONFIG_CRC16 Arnd Bergmann
@ 2024-05-28 12:40 ` Lazar, Lijo
0 siblings, 0 replies; 2+ messages in thread
From: Lazar, Lijo @ 2024-05-28 12:40 UTC (permalink / raw)
To: Arnd Bergmann, Felix Kuehling
Cc: Arnd Bergmann, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Harish Kasiviswanathan, amd-gfx,
dri-devel, linux-kernel
On 5/28/2024 5:20 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The amdkfd support fails to link when CONFIG_CRC16 is disabled:
>
> aarch64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_topology.o: in function `kfd_topology_add_device':
> kfd_topology.c:(.text+0x3a4c): undefined reference to `crc16'
>
> This is a library module that needs to be selected from every user.
>
> Fixes: 3ed181b8ff43 ("drm/amdkfd: Ensure gpu_id is unique")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the patch; this is already addressed with -
https://patchwork.freedesktop.org/patch/594816/
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index d3c3d3ab7225..f82595af34bf 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -6,6 +6,7 @@
> config HSA_AMD
> bool "HSA kernel driver for AMD GPU devices"
> depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64)
> + select CRC16
> select HMM_MIRROR
> select MMU_NOTIFIER
> select DRM_AMDGPU_USERPTR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-28 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 11:50 [PATCH] drm/amdkfd: select CONFIG_CRC16 Arnd Bergmann
2024-05-28 12:40 ` Lazar, Lijo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox