* [PATCH 1/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN10
2024-11-05 14:02 [PATCH 0/2] drm/amd/display: Fix Power Gating Configuration Zicheng Qu
@ 2024-11-05 14:02 ` Zicheng Qu
2024-11-06 15:27 ` Alex Deucher
2024-11-05 14:02 ` [PATCH 2/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN11 Zicheng Qu
2024-11-05 18:51 ` [PATCH 0/2] drm/amd/display: Fix Power Gating Configuration Rodrigo Siqueira Jordao
2 siblings, 1 reply; 6+ messages in thread
From: Zicheng Qu @ 2024-11-05 14:02 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, simona, Alvin.Lee2,
chiahsuan.chung, alex.hung, wenjing.liu, Dillon.Varone,
george.shen, mwen, yi-lchen, martin.leung, yongqiang.sun,
tony.cheng, amd-gfx, dri-devel, linux-kernel
Cc: tanghui20, zhangqiao22, judy.chenhui, quzicheng
The current implementation incorrectly updates DOMAIN10_PG_CONFIG with
DOMAIN8_POWER_FORCEON, which is not the intended behavior. This patch
corrects the power gating configuration by updating DOMAIN10_PG_CONFIG
with DOMAIN10_POWER_FORCEON, preventing potential issues related to
power management.
Fixes: 46825fcfbe16 ("drm/amd/display: avoid power gate domains that doesn't exist")
Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
---
drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
index a80c08582932..67a77274d813 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
@@ -317,7 +317,7 @@ void dcn20_enable_power_gating_plane(
if (REG(DOMAIN8_PG_CONFIG))
REG_UPDATE(DOMAIN8_PG_CONFIG, DOMAIN8_POWER_FORCEON, force_on);
if (REG(DOMAIN10_PG_CONFIG))
- REG_UPDATE(DOMAIN10_PG_CONFIG, DOMAIN8_POWER_FORCEON, force_on);
+ REG_UPDATE(DOMAIN10_PG_CONFIG, DOMAIN10_POWER_FORCEON, force_on);
/* DPP0/1/2/3/4/5 */
REG_UPDATE(DOMAIN1_PG_CONFIG, DOMAIN1_POWER_FORCEON, force_on);
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN10
2024-11-05 14:02 ` [PATCH 1/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN10 Zicheng Qu
@ 2024-11-06 15:27 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2024-11-06 15:27 UTC (permalink / raw)
To: Zicheng Qu
Cc: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, simona, Alvin.Lee2,
chiahsuan.chung, alex.hung, wenjing.liu, Dillon.Varone,
george.shen, mwen, yi-lchen, martin.leung, yongqiang.sun,
tony.cheng, amd-gfx, dri-devel, linux-kernel, tanghui20,
zhangqiao22, judy.chenhui
On Wed, Nov 6, 2024 at 3:18 AM Zicheng Qu <quzicheng@huawei.com> wrote:
>
> The current implementation incorrectly updates DOMAIN10_PG_CONFIG with
> DOMAIN8_POWER_FORCEON, which is not the intended behavior. This patch
> corrects the power gating configuration by updating DOMAIN10_PG_CONFIG
> with DOMAIN10_POWER_FORCEON, preventing potential issues related to
> power management.
The bitfield is the same for both so there is no functional change.
This is just a cosmetic change to use the right bitfield macro.
Alex
>
> Fixes: 46825fcfbe16 ("drm/amd/display: avoid power gate domains that doesn't exist")
> Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
> ---
> drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
> index a80c08582932..67a77274d813 100644
> --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
> @@ -317,7 +317,7 @@ void dcn20_enable_power_gating_plane(
> if (REG(DOMAIN8_PG_CONFIG))
> REG_UPDATE(DOMAIN8_PG_CONFIG, DOMAIN8_POWER_FORCEON, force_on);
> if (REG(DOMAIN10_PG_CONFIG))
> - REG_UPDATE(DOMAIN10_PG_CONFIG, DOMAIN8_POWER_FORCEON, force_on);
> + REG_UPDATE(DOMAIN10_PG_CONFIG, DOMAIN10_POWER_FORCEON, force_on);
>
> /* DPP0/1/2/3/4/5 */
> REG_UPDATE(DOMAIN1_PG_CONFIG, DOMAIN1_POWER_FORCEON, force_on);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN11
2024-11-05 14:02 [PATCH 0/2] drm/amd/display: Fix Power Gating Configuration Zicheng Qu
2024-11-05 14:02 ` [PATCH 1/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN10 Zicheng Qu
@ 2024-11-05 14:02 ` Zicheng Qu
2024-11-06 15:27 ` Alex Deucher
2024-11-05 18:51 ` [PATCH 0/2] drm/amd/display: Fix Power Gating Configuration Rodrigo Siqueira Jordao
2 siblings, 1 reply; 6+ messages in thread
From: Zicheng Qu @ 2024-11-05 14:02 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, simona, Alvin.Lee2,
chiahsuan.chung, alex.hung, wenjing.liu, Dillon.Varone,
george.shen, mwen, yi-lchen, martin.leung, yongqiang.sun,
tony.cheng, amd-gfx, dri-devel, linux-kernel
Cc: tanghui20, zhangqiao22, judy.chenhui, quzicheng
The current implementation incorrectly updates DOMAIN11_PG_CONFIG with
DOMAIN9_POWER_FORCEON, which is not the intended behavior. This patch
corrects the power gating configuration by updating DOMAIN11_PG_CONFIG
with DOMAIN11_POWER_FORCEON, preventing potential issues related to
power management.
Fixes: 46825fcfbe16 ("drm/amd/display: avoid power gate domains that doesn't exist")
Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
---
drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
index 67a77274d813..bc21eb0b2760 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
@@ -327,7 +327,7 @@ void dcn20_enable_power_gating_plane(
if (REG(DOMAIN9_PG_CONFIG))
REG_UPDATE(DOMAIN9_PG_CONFIG, DOMAIN9_POWER_FORCEON, force_on);
if (REG(DOMAIN11_PG_CONFIG))
- REG_UPDATE(DOMAIN11_PG_CONFIG, DOMAIN9_POWER_FORCEON, force_on);
+ REG_UPDATE(DOMAIN11_PG_CONFIG, DOMAIN11_POWER_FORCEON, force_on);
/* DCS0/1/2/3/4/5 */
REG_UPDATE(DOMAIN16_PG_CONFIG, DOMAIN16_POWER_FORCEON, force_on);
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN11
2024-11-05 14:02 ` [PATCH 2/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN11 Zicheng Qu
@ 2024-11-06 15:27 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2024-11-06 15:27 UTC (permalink / raw)
To: Zicheng Qu
Cc: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, simona, Alvin.Lee2,
chiahsuan.chung, alex.hung, wenjing.liu, Dillon.Varone,
george.shen, mwen, yi-lchen, martin.leung, yongqiang.sun,
tony.cheng, amd-gfx, dri-devel, linux-kernel, tanghui20,
zhangqiao22, judy.chenhui
On Wed, Nov 6, 2024 at 3:24 AM Zicheng Qu <quzicheng@huawei.com> wrote:
>
> The current implementation incorrectly updates DOMAIN11_PG_CONFIG with
> DOMAIN9_POWER_FORCEON, which is not the intended behavior. This patch
> corrects the power gating configuration by updating DOMAIN11_PG_CONFIG
> with DOMAIN11_POWER_FORCEON, preventing potential issues related to
> power management.
The bitfield is the same for both so there is no functional change.
This is just a cosmetic change to use the right bitfield macro.
Alex
>
> Fixes: 46825fcfbe16 ("drm/amd/display: avoid power gate domains that doesn't exist")
> Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
> ---
> drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
> index 67a77274d813..bc21eb0b2760 100644
> --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
> @@ -327,7 +327,7 @@ void dcn20_enable_power_gating_plane(
> if (REG(DOMAIN9_PG_CONFIG))
> REG_UPDATE(DOMAIN9_PG_CONFIG, DOMAIN9_POWER_FORCEON, force_on);
> if (REG(DOMAIN11_PG_CONFIG))
> - REG_UPDATE(DOMAIN11_PG_CONFIG, DOMAIN9_POWER_FORCEON, force_on);
> + REG_UPDATE(DOMAIN11_PG_CONFIG, DOMAIN11_POWER_FORCEON, force_on);
>
> /* DCS0/1/2/3/4/5 */
> REG_UPDATE(DOMAIN16_PG_CONFIG, DOMAIN16_POWER_FORCEON, force_on);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] drm/amd/display: Fix Power Gating Configuration
2024-11-05 14:02 [PATCH 0/2] drm/amd/display: Fix Power Gating Configuration Zicheng Qu
2024-11-05 14:02 ` [PATCH 1/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN10 Zicheng Qu
2024-11-05 14:02 ` [PATCH 2/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN11 Zicheng Qu
@ 2024-11-05 18:51 ` Rodrigo Siqueira Jordao
2 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira Jordao @ 2024-11-05 18:51 UTC (permalink / raw)
To: Zicheng Qu
Cc: tanghui20, zhangqiao22, judy.chenhui, harry.wentland, sunpeng.li,
alexander.deucher, christian.koenig, Xinhui.Pan, airlied, simona,
Alvin.Lee2, chiahsuan.chung, alex.hung, wenjing.liu,
Dillon.Varone, george.shen, mwen, yi-lchen, martin.leung,
yongqiang.sun, tony.cheng, amd-gfx, dri-devel
On 11/5/24 7:02 AM, Zicheng Qu wrote:
> Hi all,
>
> I am submitting two patches to correct power gating configurations in
> the AMD display driver.
>
> 1. Patch 1/2 (Fixes: 46825fcfbe16): Corrects DOMAIN10_PG_CONFIG to use
> DOMAIN10_POWER_FORCEON.
> 2. Patch 2/2 (Fixes: 46825fcfbe16): Corrects DOMAIN11_PG_CONFIG to use
> DOMAIN11_POWER_FORCEON.
>
Hi Zicheng,
Do you have more details about the issue? Could you describe the bug
that you are fixing?
Thanks
Siqueira
> Thanks for reviewing!
>
> Zicheng Qu (2):
> drm/amd/display: Fix incorrect power gating configuration for DOMAIN10
> drm/amd/display: Fix incorrect power gating configuration for DOMAIN11
>
> drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
^ permalink raw reply [flat|nested] 6+ messages in thread