From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Yifan Zha <Yifan.Zha@amd.com>,
amd-gfx@lists.freedesktop.org, Alexander.Deucher@amd.com,
Hawking.Zhang@amd.com
Cc: Horace.Chen@amd.com, haijun.chang@amd.com
Subject: Re: [PATCH] drm/amd/pm: Update smu_v13_0_0 SRIOV VF flag in msg mapping table
Date: Tue, 21 Jan 2025 15:18:42 +0530 [thread overview]
Message-ID: <7bcb053d-dc8a-4b3c-952d-d23197862c3f@amd.com> (raw)
In-Reply-To: <20250120034918.1835607-1-Yifan.Zha@amd.com>
On 1/20/2025 9:19 AM, Yifan Zha wrote:
> [Why]
> Under SRIOV VF, driver send a VF unsupportted smu message causing
> a failure.
>
> [How]
> Update smu_v13_0_0 message mapping table based on PMFW.
>
Does this hold good for 1VF case also?
Thanks,
Lijo
> Signed-off-by: Yifan Zha <Yifan.Zha@amd.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> index 0551a3311217..985355bf78b2 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> @@ -126,7 +126,7 @@ static struct cmn2asic_msg_mapping smu_v13_0_0_message_map[SMU_MSG_MAX_COUNT] =
> MSG_MAP(DisableSmuFeaturesHigh, PPSMC_MSG_DisableSmuFeaturesHigh, 1),
> MSG_MAP(GetEnabledSmuFeaturesLow, PPSMC_MSG_GetRunningSmuFeaturesLow, 1),
> MSG_MAP(GetEnabledSmuFeaturesHigh, PPSMC_MSG_GetRunningSmuFeaturesHigh, 1),
> - MSG_MAP(SetWorkloadMask, PPSMC_MSG_SetWorkloadMask, 1),
> + MSG_MAP(SetWorkloadMask, PPSMC_MSG_SetWorkloadMask, 0),
> MSG_MAP(SetPptLimit, PPSMC_MSG_SetPptLimit, 0),
> MSG_MAP(SetDriverDramAddrHigh, PPSMC_MSG_SetDriverDramAddrHigh, 1),
> MSG_MAP(SetDriverDramAddrLow, PPSMC_MSG_SetDriverDramAddrLow, 1),
> @@ -140,7 +140,7 @@ static struct cmn2asic_msg_mapping smu_v13_0_0_message_map[SMU_MSG_MAX_COUNT] =
> MSG_MAP(ExitBaco, PPSMC_MSG_ExitBaco, 0),
> MSG_MAP(SetSoftMinByFreq, PPSMC_MSG_SetSoftMinByFreq, 1),
> MSG_MAP(SetSoftMaxByFreq, PPSMC_MSG_SetSoftMaxByFreq, 1),
> - MSG_MAP(SetHardMinByFreq, PPSMC_MSG_SetHardMinByFreq, 1),
> + MSG_MAP(SetHardMinByFreq, PPSMC_MSG_SetHardMinByFreq, 0),
> MSG_MAP(SetHardMaxByFreq, PPSMC_MSG_SetHardMaxByFreq, 0),
> MSG_MAP(GetMinDpmFreq, PPSMC_MSG_GetMinDpmFreq, 1),
> MSG_MAP(GetMaxDpmFreq, PPSMC_MSG_GetMaxDpmFreq, 1),
> @@ -149,7 +149,7 @@ static struct cmn2asic_msg_mapping smu_v13_0_0_message_map[SMU_MSG_MAX_COUNT] =
> MSG_MAP(PowerDownVcn, PPSMC_MSG_PowerDownVcn, 0),
> MSG_MAP(PowerUpJpeg, PPSMC_MSG_PowerUpJpeg, 0),
> MSG_MAP(PowerDownJpeg, PPSMC_MSG_PowerDownJpeg, 0),
> - MSG_MAP(GetDcModeMaxDpmFreq, PPSMC_MSG_GetDcModeMaxDpmFreq, 1),
> + MSG_MAP(GetDcModeMaxDpmFreq, PPSMC_MSG_GetDcModeMaxDpmFreq, 0),
> MSG_MAP(OverridePcieParameters, PPSMC_MSG_OverridePcieParameters, 0),
> MSG_MAP(DramLogSetDramAddrHigh, PPSMC_MSG_DramLogSetDramAddrHigh, 0),
> MSG_MAP(DramLogSetDramAddrLow, PPSMC_MSG_DramLogSetDramAddrLow, 0),
next prev parent reply other threads:[~2025-01-21 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 3:49 [PATCH] drm/amd/pm: Update smu_v13_0_0 SRIOV VF flag in msg mapping table Yifan Zha
2025-01-21 9:48 ` Lazar, Lijo [this message]
2025-01-22 10:28 ` Zha, YiFan(Even)
2025-01-22 11:17 ` Lazar, Lijo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bcb053d-dc8a-4b3c-952d-d23197862c3f@amd.com \
--to=lijo.lazar@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Horace.Chen@amd.com \
--cc=Yifan.Zha@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=haijun.chang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox