* [PATCH] drm/amd/amdgpu: Avoid fault when allocating an empty buffer object
@ 2018-09-17 18:07 Tom St Denis
[not found] ` <20180917180711.29594-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Tom St Denis @ 2018-09-17 18:07 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Tom St Denis
Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 84d82d5382f9..c1387efc0c91 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -348,7 +348,8 @@ int amdgpu_bo_create_kernel(struct amdgpu_device *adev,
if (r)
return r;
- amdgpu_bo_unreserve(*bo_ptr);
+ if (*bo_ptr)
+ amdgpu_bo_unreserve(*bo_ptr);
return 0;
}
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/amdgpu: Avoid fault when allocating an empty buffer object
[not found] ` <20180917180711.29594-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
@ 2018-09-17 18:08 ` Christian König
[not found] ` <9d13625d-f0da-cf16-2e0a-78db28dc7a1a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-18 5:49 ` Huang Rui
1 sibling, 1 reply; 4+ messages in thread
From: Christian König @ 2018-09-17 18:08 UTC (permalink / raw)
To: Tom St Denis, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Am 17.09.2018 um 20:07 schrieb Tom St Denis:
> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
You was faster than me :)
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 84d82d5382f9..c1387efc0c91 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -348,7 +348,8 @@ int amdgpu_bo_create_kernel(struct amdgpu_device *adev,
> if (r)
> return r;
>
> - amdgpu_bo_unreserve(*bo_ptr);
> + if (*bo_ptr)
> + amdgpu_bo_unreserve(*bo_ptr);
>
> return 0;
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/amdgpu: Avoid fault when allocating an empty buffer object
[not found] ` <9d13625d-f0da-cf16-2e0a-78db28dc7a1a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-09-17 18:11 ` Tom St Denis
0 siblings, 0 replies; 4+ messages in thread
From: Tom St Denis @ 2018-09-17 18:11 UTC (permalink / raw)
To: christian.koenig-5C7GfCeVMHo,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 2018-09-17 2:08 p.m., Christian König wrote:
> Am 17.09.2018 um 20:07 schrieb Tom St Denis:
>> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> You was faster than me :)
Been a while since I got a patch on the kernel side... need to keep up
numbers :-)
Tom
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 84d82d5382f9..c1387efc0c91 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -348,7 +348,8 @@ int amdgpu_bo_create_kernel(struct amdgpu_device
>> *adev,
>> if (r)
>> return r;
>> - amdgpu_bo_unreserve(*bo_ptr);
>> + if (*bo_ptr)
>> + amdgpu_bo_unreserve(*bo_ptr);
>> return 0;
>> }
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/amdgpu: Avoid fault when allocating an empty buffer object
[not found] ` <20180917180711.29594-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2018-09-17 18:08 ` Christian König
@ 2018-09-18 5:49 ` Huang Rui
1 sibling, 0 replies; 4+ messages in thread
From: Huang Rui @ 2018-09-18 5:49 UTC (permalink / raw)
To: Tom St Denis; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Mon, Sep 17, 2018 at 02:07:11PM -0400, Tom St Denis wrote:
> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 84d82d5382f9..c1387efc0c91 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -348,7 +348,8 @@ int amdgpu_bo_create_kernel(struct amdgpu_device *adev,
> if (r)
> return r;
>
> - amdgpu_bo_unreserve(*bo_ptr);
> + if (*bo_ptr)
> + amdgpu_bo_unreserve(*bo_ptr);
>
> return 0;
> }
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-18 5:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-17 18:07 [PATCH] drm/amd/amdgpu: Avoid fault when allocating an empty buffer object Tom St Denis
[not found] ` <20180917180711.29594-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2018-09-17 18:08 ` Christian König
[not found] ` <9d13625d-f0da-cf16-2e0a-78db28dc7a1a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-17 18:11 ` Tom St Denis
2018-09-18 5:49 ` Huang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox