From: "Chung, ChiaHsuan (Tom)" <chiahsuan.chung@amd.com>
To: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: amd-gfx@lists.freedesktop.org, Roman Li <roman.li@amd.com>,
Alex Hung <alex.hung@amd.com>,
Harry Wentland <harry.wentland@amd.com>,
Hamza Mahfooz <hamza.mahfooz@amd.com>
Subject: Re: [PATCH] drm/amd/display: Align 'dpp401_dscl_program_isharp' with actual function parameters
Date: Wed, 31 Jul 2024 13:27:52 +0800 [thread overview]
Message-ID: <7eb9ab9e-104f-4dc7-a1ec-63dfa2cadaba@amd.com> (raw)
In-Reply-To: <20240730041137.200169-1-srinivasan.shanmugam@amd.com>
Reviewed-by: Tom Chung <chiahsuan.chung@amd.com>
On 7/30/2024 12:11 PM, Srinivasan Shanmugam wrote:
> This commit corrects the function comment for
> 'dpp401_dscl_program_isharp' in 'dcn401_dpp_dscl.c'. The comment
> previously included a description for a non-existent parameter
> 'bs_coeffs_updated'. This parameter description has been removed to
> reflect the function's actual parameters.
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dpp/dcn401/dcn401_dpp_dscl.c:981: warning: Excess function parameter 'bs_coeffs_updated' description in 'dpp401_dscl_program_isharp'
>
> Cc: Tom Chung <chiahsuan.chung@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Roman Li <roman.li@amd.com>
> Cc: Alex Hung <alex.hung@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c b/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
> index 88d24e36fe00..505929800426 100644
> --- a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
> +++ b/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
> @@ -971,7 +971,6 @@ static void dpp401_dscl_set_isharp_filter(
> *
> * @dpp_base: High level DPP struct
> * @scl_data: scalaer_data info
> - * @bs_coeffs_updated: coeffs update flag
> *
> * This is the primary function to program isharp
> *
prev parent reply other threads:[~2024-07-31 5:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 4:11 [PATCH] drm/amd/display: Align 'dpp401_dscl_program_isharp' with actual function parameters Srinivasan Shanmugam
2024-07-31 5:27 ` Chung, ChiaHsuan (Tom) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eb9ab9e-104f-4dc7-a1ec-63dfa2cadaba@amd.com \
--to=chiahsuan.chung@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=alex.hung@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=hamza.mahfooz@amd.com \
--cc=harry.wentland@amd.com \
--cc=roman.li@amd.com \
--cc=srinivasan.shanmugam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox