* [PATCH] drm/amd/display: Align 'dpp401_dscl_program_isharp' with actual function parameters
@ 2024-07-30 4:11 Srinivasan Shanmugam
2024-07-31 5:27 ` Chung, ChiaHsuan (Tom)
0 siblings, 1 reply; 2+ messages in thread
From: Srinivasan Shanmugam @ 2024-07-30 4:11 UTC (permalink / raw)
To: Rodrigo Siqueira, Aurabindo Pillai
Cc: amd-gfx, Srinivasan Shanmugam, Tom Chung, Roman Li, Alex Hung,
Harry Wentland, Hamza Mahfooz
This commit corrects the function comment for
'dpp401_dscl_program_isharp' in 'dcn401_dpp_dscl.c'. The comment
previously included a description for a non-existent parameter
'bs_coeffs_updated'. This parameter description has been removed to
reflect the function's actual parameters.
Fixes the below with gcc W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/dpp/dcn401/dcn401_dpp_dscl.c:981: warning: Excess function parameter 'bs_coeffs_updated' description in 'dpp401_dscl_program_isharp'
Cc: Tom Chung <chiahsuan.chung@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Roman Li <roman.li@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
---
drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c b/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
index 88d24e36fe00..505929800426 100644
--- a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
+++ b/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
@@ -971,7 +971,6 @@ static void dpp401_dscl_set_isharp_filter(
*
* @dpp_base: High level DPP struct
* @scl_data: scalaer_data info
- * @bs_coeffs_updated: coeffs update flag
*
* This is the primary function to program isharp
*
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Align 'dpp401_dscl_program_isharp' with actual function parameters
2024-07-30 4:11 [PATCH] drm/amd/display: Align 'dpp401_dscl_program_isharp' with actual function parameters Srinivasan Shanmugam
@ 2024-07-31 5:27 ` Chung, ChiaHsuan (Tom)
0 siblings, 0 replies; 2+ messages in thread
From: Chung, ChiaHsuan (Tom) @ 2024-07-31 5:27 UTC (permalink / raw)
To: Srinivasan Shanmugam, Rodrigo Siqueira, Aurabindo Pillai
Cc: amd-gfx, Roman Li, Alex Hung, Harry Wentland, Hamza Mahfooz
Reviewed-by: Tom Chung <chiahsuan.chung@amd.com>
On 7/30/2024 12:11 PM, Srinivasan Shanmugam wrote:
> This commit corrects the function comment for
> 'dpp401_dscl_program_isharp' in 'dcn401_dpp_dscl.c'. The comment
> previously included a description for a non-existent parameter
> 'bs_coeffs_updated'. This parameter description has been removed to
> reflect the function's actual parameters.
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dpp/dcn401/dcn401_dpp_dscl.c:981: warning: Excess function parameter 'bs_coeffs_updated' description in 'dpp401_dscl_program_isharp'
>
> Cc: Tom Chung <chiahsuan.chung@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Roman Li <roman.li@amd.com>
> Cc: Alex Hung <alex.hung@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c b/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
> index 88d24e36fe00..505929800426 100644
> --- a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
> +++ b/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
> @@ -971,7 +971,6 @@ static void dpp401_dscl_set_isharp_filter(
> *
> * @dpp_base: High level DPP struct
> * @scl_data: scalaer_data info
> - * @bs_coeffs_updated: coeffs update flag
> *
> * This is the primary function to program isharp
> *
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-31 5:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-30 4:11 [PATCH] drm/amd/display: Align 'dpp401_dscl_program_isharp' with actual function parameters Srinivasan Shanmugam
2024-07-31 5:27 ` Chung, ChiaHsuan (Tom)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox