[PATCH] drm/radeon: ratelimit bo warnings

[PATCH] drm/radeon: ratelimit bo warnings

[Nick Alcock]

So a few days ago I started getting sprays of these warnings --
sorry, but because it was a few days ago I'm not sure what I was
running at the time (but it was probably either Stellaris or Chromium).

Sep 25 22:06:34 mutilate err: : [  544.718905] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
Sep 25 22:06:34 mutilate err: : [  544.718909] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
Sep 25 22:06:34 mutilate err: : [  544.719710] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
Sep 25 22:06:34 mutilate err: : [  544.719714] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
Sep 25 22:06:34 mutilate err: : [  544.719862] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
Sep 25 22:06:34 mutilate err: : [  544.719865] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
Sep 25 22:06:34 mutilate err: : [  544.720772] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
Sep 25 22:06:34 mutilate err: : [  544.720778] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
Sep 25 22:06:34 mutilate warning: : [  544.721415] radeon 0000:01:00.0: vbo resource seems too big for the bo

followed by a massive stream of "vbo resource seems too big for the bo".

The most extreme flood ran from 23:01:58 to 23:02:47 and emitted 91,000
lines of log in that time.  This... seems excessive, given that each log
message after the first contains more or less no information.

So ratelimit these messages. (We probably want to see at least *some* so
that the underlying bug can be fixed -- always assuming the bug isn't in
unfixable closed-source game code somewhere.)

This patch is against 4.18.11: I saw the warnings on 4.17.6 with Mesa
18.1.2, but nothing much seems to have changed in this area so I bet
this could recur.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
---
 drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
index 54324330b91f..f471537c852f 100644
--- a/drivers/gpu/drm/radeon/evergreen_cs.c
+++ b/drivers/gpu/drm/radeon/evergreen_cs.c
@@ -2416,7 +2416,7 @@ static int evergreen_packet3_check(struct radeon_cs_parser *p,
 				size = radeon_get_ib_value(p, idx+1+(i*8)+1);
 				if (p->rdev && (size + offset) > radeon_bo_size(reloc->robj)) {
 					/* force size to size of the buffer */
-					dev_warn(p->dev, "vbo resource seems too big for the bo\n");
+					dev_warn_ratelimited(p->dev, "vbo resource seems too big for the bo\n");
 					ib[idx+1+(i*8)+1] = radeon_bo_size(reloc->robj) - offset;
 				}
 
-- 
2.19.0.232.g4c0b389819

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/radeon: ratelimit bo warnings

[Michel Dänzer]

On 2018-10-04 9:58 p.m., Nick Alcock wrote:
> So a few days ago I started getting sprays of these warnings --
> sorry, but because it was a few days ago I'm not sure what I was
> running at the time (but it was probably either Stellaris or Chromium).
> 
> Sep 25 22:06:34 mutilate err: : [  544.718905] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
> Sep 25 22:06:34 mutilate err: : [  544.718909] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
> Sep 25 22:06:34 mutilate err: : [  544.719710] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
> Sep 25 22:06:34 mutilate err: : [  544.719714] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
> Sep 25 22:06:34 mutilate err: : [  544.719862] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
> Sep 25 22:06:34 mutilate err: : [  544.719865] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
> Sep 25 22:06:34 mutilate err: : [  544.720772] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
> Sep 25 22:06:34 mutilate err: : [  544.720778] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!

These are likely due to https://bugs.freedesktop.org/105381 , fixed in
xf86-video-ati 18.1.0.


> Sep 25 22:06:34 mutilate warning: : [  544.721415] radeon 0000:01:00.0: vbo resource seems too big for the bo

Not sure this can also be caused by the above, but I guess it's possible.


> followed by a massive stream of "vbo resource seems too big for the bo".
> 
> The most extreme flood ran from 23:01:58 to 23:02:47 and emitted 91,000
> lines of log in that time.  This... seems excessive, given that each log
> message after the first contains more or less no information.
> 
> So ratelimit these messages. (We probably want to see at least *some* so
> that the underlying bug can be fixed -- always assuming the bug isn't in
> unfixable closed-source game code somewhere.)
> 
> This patch is against 4.18.11: I saw the warnings on 4.17.6 with Mesa
> 18.1.2, but nothing much seems to have changed in this area so I bet
> this could recur.

Not sure it makes sense to have the last paragraph in the Git commit
log, but either way:

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>


> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> ---
>  drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> index 54324330b91f..f471537c852f 100644
> --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> @@ -2416,7 +2416,7 @@ static int evergreen_packet3_check(struct radeon_cs_parser *p,
>  				size = radeon_get_ib_value(p, idx+1+(i*8)+1);
>  				if (p->rdev && (size + offset) > radeon_bo_size(reloc->robj)) {
>  					/* force size to size of the buffer */
> -					dev_warn(p->dev, "vbo resource seems too big for the bo\n");
> +					dev_warn_ratelimited(p->dev, "vbo resource seems too big for the bo\n");
>  					ib[idx+1+(i*8)+1] = radeon_bo_size(reloc->robj) - offset;
>  				}
>  
> 




-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/radeon: ratelimit bo warnings

[Nick Alcock]

On 5 Oct 2018, Michel Dänzer told this:

> On 2018-10-04 9:58 p.m., Nick Alcock wrote:
>> So a few days ago I started getting sprays of these warnings --
>> sorry, but because it was a few days ago I'm not sure what I was
>> running at the time (but it was probably either Stellaris or Chromium).
>> 
>> Sep 25 22:06:34 mutilate err: : [  544.718905] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>> Sep 25 22:06:34 mutilate err: : [  544.718909] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>> Sep 25 22:06:34 mutilate err: : [  544.719710] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>> Sep 25 22:06:34 mutilate err: : [  544.719714] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>> Sep 25 22:06:34 mutilate err: : [  544.719862] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>> Sep 25 22:06:34 mutilate err: : [  544.719865] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>> Sep 25 22:06:34 mutilate err: : [  544.720772] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>> Sep 25 22:06:34 mutilate err: : [  544.720778] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>
> These are likely due to https://bugs.freedesktop.org/105381 , fixed in
> xf86-video-ati 18.1.0.

This is with X server 1.20.0 and xf86-video-ati 18.0.1, so I concur.

I'll upgrade once I'm back near the machine in question (I mean, I could
upgrade now but I'm 200 miles away so running an X server on it at
present is a bit pointless).

>> Sep 25 22:06:34 mutilate warning: : [  544.721415] radeon 0000:01:00.0: vbo resource seems too big for the bo
>
> Not sure this can also be caused by the above, but I guess it's possible.

It can clearly be caused by *something*, and without anything obvious
going wrong in the user interface you can clearly get crazy log flooding
without the user being any the wiser. It doesn't really matter what
causes it, just that it is causable. :)

>> This patch is against 4.18.11: I saw the warnings on 4.17.6 with Mesa
>> 18.1.2, but nothing much seems to have changed in this area so I bet
>> this could recur.
>
> Not sure it makes sense to have the last paragraph in the Git commit
> log, but either way:

Yeah, I stuck it in the wrong place in the mail. (I meant to move it and
then completely forgot. Mea culpa.)

> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>

Thanks!

-- 
NULL && (void)
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/radeon: ratelimit bo warnings

[Michel Dänzer]

On 2018-10-05 7:14 p.m., Nick Alcock wrote:
> On 5 Oct 2018, Michel Dänzer told this:
> 
>> On 2018-10-04 9:58 p.m., Nick Alcock wrote:
>>> So a few days ago I started getting sprays of these warnings --
>>> sorry, but because it was a few days ago I'm not sure what I was
>>> running at the time (but it was probably either Stellaris or Chromium).
>>>
>>> Sep 25 22:06:34 mutilate err: : [  544.718905] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>>> Sep 25 22:06:34 mutilate err: : [  544.718909] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>>> Sep 25 22:06:34 mutilate err: : [  544.719710] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>>> Sep 25 22:06:34 mutilate err: : [  544.719714] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>>> Sep 25 22:06:34 mutilate err: : [  544.719862] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>>> Sep 25 22:06:34 mutilate err: : [  544.719865] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>>> Sep 25 22:06:34 mutilate err: : [  544.720772] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>>> Sep 25 22:06:34 mutilate err: : [  544.720778] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>>
>> These are likely due to https://bugs.freedesktop.org/105381 , fixed in
>> xf86-video-ati 18.1.0.
> 
> This is with X server 1.20.0 and xf86-video-ati 18.0.1, so I concur.
> 
> I'll upgrade once I'm back near the machine in question (I mean, I could
> upgrade now but I'm 200 miles away so running an X server on it at
> present is a bit pointless).
> 
>>> Sep 25 22:06:34 mutilate warning: : [  544.721415] radeon 0000:01:00.0: vbo resource seems too big for the bo
>>
>> Not sure this can also be caused by the above, but I guess it's possible.
> 
> It can clearly be caused by *something*, and without anything obvious
> going wrong in the user interface you can clearly get crazy log flooding
> without the user being any the wiser. It doesn't really matter what
> causes it, just that it is causable. :)
> 
>>> This patch is against 4.18.11: I saw the warnings on 4.17.6 with Mesa
>>> 18.1.2, but nothing much seems to have changed in this area so I bet
>>> this could recur.
>>
>> Not sure it makes sense to have the last paragraph in the Git commit
>> log, but either way:
> 
> Yeah, I stuck it in the wrong place in the mail. (I meant to move it and
> then completely forgot. Mea culpa.)
> 
>> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
> 
> Thanks!

Merged the patch for amd-staging-drm-next, will probably land for 4.20,
thanks!


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/radeon: ratelimit bo warnings

[Nick Alcock]

On 9 Oct 2018, Michel Dänzer stated:

> On 2018-10-05 7:14 p.m., Nick Alcock wrote:
>> On 5 Oct 2018, Michel Dänzer told this:
>> 
>>> On 2018-10-04 9:58 p.m., Nick Alcock wrote:
>>>> So a few days ago I started getting sprays of these warnings --
>>>> sorry, but because it was a few days ago I'm not sure what I was
>>>> running at the time (but it was probably either Stellaris or Chromium).
>>>>
>>>> Sep 25 22:06:34 mutilate err: : [  544.718905] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>>>> Sep 25 22:06:34 mutilate err: : [  544.718909] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>>>> Sep 25 22:06:34 mutilate err: : [  544.719710] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>>>> Sep 25 22:06:34 mutilate err: : [  544.719714] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>>>> Sep 25 22:06:34 mutilate err: : [  544.719862] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>>>> Sep 25 22:06:34 mutilate err: : [  544.719865] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>>>> Sep 25 22:06:34 mutilate err: : [  544.720772] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
>>>> Sep 25 22:06:34 mutilate err: : [  544.720778] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
>>>
>>> These are likely due to https://bugs.freedesktop.org/105381 , fixed in
>>> xf86-video-ati 18.1.0.
>> 
>> This is with X server 1.20.0 and xf86-video-ati 18.0.1, so I concur.
>> 
>> I'll upgrade once I'm back near the machine in question (I mean, I could
>> upgrade now but I'm 200 miles away so running an X server on it at
>> present is a bit pointless).

I have upgraded and the warnings do appear to have gone away, so thank
you for the remote diagnosis :)

> Merged the patch for amd-staging-drm-next, will probably land for 4.20,
> thanks!

Great!
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx