AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Asad Kamal <asad.kamal@amd.com>, amd-gfx@lists.freedesktop.org
Cc: hawking.zhang@amd.com, le.ma@amd.com, shiwu.zhang@amd.com,
	alexander.deucher@amd.com, kevinyang.wang@amd.com
Subject: Re: [PATCH] drm/amd/pm: Relax manual min/max clock check
Date: Thu, 30 Apr 2026 15:52:33 +0530	[thread overview]
Message-ID: <87d5b981-51ac-4e4f-8b68-2bcdd808aa4f@amd.com> (raw)
In-Reply-To: <20260430102057.4186555-1-asad.kamal@amd.com>



On 30-Apr-26 3:50 PM, Asad Kamal wrote:
> Allow min == max for the soft frequency limit when
> AMD_DPM_FORCED_LEVEL_MANUAL is used on SMU v13.0.6
> 
> Signed-off-by: Asad Kamal <asad.kamal@amd.com>

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 8d04f6e73fd7..ce520f43ab94 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -2075,9 +2075,9 @@ static int smu_v13_0_6_set_soft_freq_limited_range(struct smu_context *smu,
>   		return -EINVAL;
>   
>   	if (smu_dpm->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
> -		if (min >= max) {
> +		if (min > max) {
>   			dev_err(smu->adev->dev,
> -				"Minimum clk should be less than the maximum allowed clock\n");
> +				"Minimum clk should be less/equal to the maximum allowed clock\n");
>   			return -EINVAL;
>   		}
>   


      reply	other threads:[~2026-04-30 10:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 10:20 [PATCH] drm/amd/pm: Relax manual min/max clock check Asad Kamal
2026-04-30 10:22 ` Lazar, Lijo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d5b981-51ac-4e4f-8b68-2bcdd808aa4f@amd.com \
    --to=lijo.lazar@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=asad.kamal@amd.com \
    --cc=hawking.zhang@amd.com \
    --cc=kevinyang.wang@amd.com \
    --cc=le.ma@amd.com \
    --cc=shiwu.zhang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox