AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/pm: Relax manual min/max clock check
@ 2026-04-30 10:20 Asad Kamal
  2026-04-30 10:22 ` Lazar, Lijo
  0 siblings, 1 reply; 2+ messages in thread
From: Asad Kamal @ 2026-04-30 10:20 UTC (permalink / raw)
  To: amd-gfx
  Cc: lijo.lazar, hawking.zhang, le.ma, shiwu.zhang, alexander.deucher,
	kevinyang.wang, asad.kamal

Allow min == max for the soft frequency limit when
AMD_DPM_FORCED_LEVEL_MANUAL is used on SMU v13.0.6

Signed-off-by: Asad Kamal <asad.kamal@amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index 8d04f6e73fd7..ce520f43ab94 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -2075,9 +2075,9 @@ static int smu_v13_0_6_set_soft_freq_limited_range(struct smu_context *smu,
 		return -EINVAL;
 
 	if (smu_dpm->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
-		if (min >= max) {
+		if (min > max) {
 			dev_err(smu->adev->dev,
-				"Minimum clk should be less than the maximum allowed clock\n");
+				"Minimum clk should be less/equal to the maximum allowed clock\n");
 			return -EINVAL;
 		}
 
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amd/pm: Relax manual min/max clock check
  2026-04-30 10:20 [PATCH] drm/amd/pm: Relax manual min/max clock check Asad Kamal
@ 2026-04-30 10:22 ` Lazar, Lijo
  0 siblings, 0 replies; 2+ messages in thread
From: Lazar, Lijo @ 2026-04-30 10:22 UTC (permalink / raw)
  To: Asad Kamal, amd-gfx
  Cc: hawking.zhang, le.ma, shiwu.zhang, alexander.deucher,
	kevinyang.wang



On 30-Apr-26 3:50 PM, Asad Kamal wrote:
> Allow min == max for the soft frequency limit when
> AMD_DPM_FORCED_LEVEL_MANUAL is used on SMU v13.0.6
> 
> Signed-off-by: Asad Kamal <asad.kamal@amd.com>

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 8d04f6e73fd7..ce520f43ab94 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -2075,9 +2075,9 @@ static int smu_v13_0_6_set_soft_freq_limited_range(struct smu_context *smu,
>   		return -EINVAL;
>   
>   	if (smu_dpm->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
> -		if (min >= max) {
> +		if (min > max) {
>   			dev_err(smu->adev->dev,
> -				"Minimum clk should be less than the maximum allowed clock\n");
> +				"Minimum clk should be less/equal to the maximum allowed clock\n");
>   			return -EINVAL;
>   		}
>   


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-30 10:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-30 10:20 [PATCH] drm/amd/pm: Relax manual min/max clock check Asad Kamal
2026-04-30 10:22 ` Lazar, Lijo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox