AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: Remove unused variable in amdgpu_device_gpu_recover
@ 2018-05-23 17:08 Harry Wentland
       [not found] ` <20180523170819.18775-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Harry Wentland @ 2018-05-23 17:08 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	andrey.grodzovsky-5C7GfCeVMHo
  Cc: Harry Wentland

It throws an unused variable warning.

Signed-off-by: Harry Wentland <harry.wentland@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index c1654a4dfd82..57a4f393ada3 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3179,7 +3179,6 @@ static int amdgpu_device_reset_sriov(struct amdgpu_device *adev,
 int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
 			      struct amdgpu_job *job, bool force)
 {
-	struct drm_atomic_state *state = NULL;
 	int i, r, resched;
 
 	if (!force && !amdgpu_device_ip_check_soft_reset(adev)) {
-- 
2.17.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: Remove unused variable in amdgpu_device_gpu_recover
       [not found] ` <20180523170819.18775-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
@ 2018-05-23 17:11   ` Andrey Grodzovsky
       [not found]     ` <2b4d2215-e1aa-cfa7-2edd-6a7fd1188c02-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Andrey Grodzovsky @ 2018-05-23 17:11 UTC (permalink / raw)
  To: Harry Wentland, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>

Andrey


On 05/23/2018 01:08 PM, Harry Wentland wrote:
> It throws an unused variable warning.
>
> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index c1654a4dfd82..57a4f393ada3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3179,7 +3179,6 @@ static int amdgpu_device_reset_sriov(struct amdgpu_device *adev,
>   int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
>   			      struct amdgpu_job *job, bool force)
>   {
> -	struct drm_atomic_state *state = NULL;
>   	int i, r, resched;
>   
>   	if (!force && !amdgpu_device_ip_check_soft_reset(adev)) {

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: Remove unused variable in amdgpu_device_gpu_recover
       [not found]     ` <2b4d2215-e1aa-cfa7-2edd-6a7fd1188c02-5C7GfCeVMHo@public.gmane.org>
@ 2018-05-24  7:00       ` Christian König
  0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2018-05-24  7:00 UTC (permalink / raw)
  To: Andrey Grodzovsky, Harry Wentland,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Reviewed-by: Christian König <christian.koenig@amd.com> as well.

Christian.

Am 23.05.2018 um 19:11 schrieb Andrey Grodzovsky:
> Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>
> Andrey
>
>
> On 05/23/2018 01:08 PM, Harry Wentland wrote:
>> It throws an unused variable warning.
>>
>> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> index c1654a4dfd82..57a4f393ada3 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> @@ -3179,7 +3179,6 @@ static int amdgpu_device_reset_sriov(struct 
>> amdgpu_device *adev,
>>   int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
>>                     struct amdgpu_job *job, bool force)
>>   {
>> -    struct drm_atomic_state *state = NULL;
>>       int i, r, resched;
>>         if (!force && !amdgpu_device_ip_check_soft_reset(adev)) {
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-24  7:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-23 17:08 [PATCH] drm/amdgpu: Remove unused variable in amdgpu_device_gpu_recover Harry Wentland
     [not found] ` <20180523170819.18775-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-05-23 17:11   ` Andrey Grodzovsky
     [not found]     ` <2b4d2215-e1aa-cfa7-2edd-6a7fd1188c02-5C7GfCeVMHo@public.gmane.org>
2018-05-24  7:00       ` Christian König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox