AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas-5C7GfCeVMHo@public.gmane.org>
To: Paul Menzel <pmenzel+amd-gfx-KUpvgZVWgV9o1qOY/usvUg@public.gmane.org>
Cc: "Li, Sun peng (Leo)" <Sunpeng.Li-5C7GfCeVMHo@public.gmane.org>,
	"Wentland, Harry" <Harry.Wentland-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amd/display: Initialize stream_update with memset
Date: Fri, 22 Mar 2019 13:54:56 +0000	[thread overview]
Message-ID: <8cfa7952-39f5-70da-4bda-e2603cb04309@amd.com> (raw)
In-Reply-To: <2afb73d6-2baf-880a-6f4e-49303f4ccded-KUpvgZVWgV9o1qOY/usvUg@public.gmane.org>

On 3/22/19 9:49 AM, Paul Menzel wrote:
> Dear Nicholas,
> 
> 
> On 03/22/19 14:15, Nicholas Kazlauskas wrote:
>> The brace initialization used here generates errors on some
>> compilers. Use memset to make this more portable.
> 
> Could you please specify the problematic compiler/toolchain in
> the commit message?
> 
> […]
> 
> 
> Kind regards,
> 
> Paul
> 

I actually meant warning in this case - since I usually build amdgpu 
with warnings as errors. In this case it was an older version of GCC 
that generated the warning (4.9). Though I think clang does as well, I 
forgot to make this patch after I saw the email from Nils Wallménius a 
while back. There were similar issues in a few other places:

https://lists.freedesktop.org/archives/amd-gfx/2019-February/031116.html

I'll update the commit message and post a v2, thanks!

Nicholas Kazlauskas
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply	other threads:[~2019-03-22 13:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 13:15 [PATCH] drm/amd/display: Initialize stream_update with memset Nicholas Kazlauskas
     [not found] ` <20190322131512.22103-1-nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
2019-03-22 13:49   ` Paul Menzel
     [not found]     ` <2afb73d6-2baf-880a-6f4e-49303f4ccded-KUpvgZVWgV9o1qOY/usvUg@public.gmane.org>
2019-03-22 13:54       ` Kazlauskas, Nicholas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cfa7952-39f5-70da-4bda-e2603cb04309@amd.com \
    --to=nicholas.kazlauskas-5c7gfcevmho@public.gmane.org \
    --cc=Harry.Wentland-5C7GfCeVMHo@public.gmane.org \
    --cc=Sunpeng.Li-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=pmenzel+amd-gfx-KUpvgZVWgV9o1qOY/usvUg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox