[PATCH] drm/amd/display: Initialize stream_update with memset

[PATCH] drm/amd/display: Initialize stream_update with memset

[Nicholas Kazlauskas]

The brace initialization used here generates errors on some
compilers. Use memset to make this more portable.

Cc: Sun peng Li <Sunpeng.Li@amd.com>
Cc: Harry Wentland <Harry.Wentland@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 5b7a85e28fab..9cdd52edfc3d 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -5982,7 +5982,9 @@ dm_determine_update_type_for_commit(struct dc *dc,
 	}
 
 	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
-		struct dc_stream_update stream_update = { 0 };
+		struct dc_stream_update stream_update;
+
+		memset(&stream_update, 0, sizeof(stream_update));
 
 		new_dm_crtc_state = to_dm_crtc_state(new_crtc_state);
 		old_dm_crtc_state = to_dm_crtc_state(old_crtc_state);
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/display: Initialize stream_update with memset

[Paul Menzel]

[-- Attachment #1.1: Type: text/plain, Size: 308 bytes --]

Dear Nicholas,


On 03/22/19 14:15, Nicholas Kazlauskas wrote:
> The brace initialization used here generates errors on some
> compilers. Use memset to make this more portable.

Could you please specify the problematic compiler/toolchain in
the commit message?

[…]


Kind regards,

Paul


[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/display: Initialize stream_update with memset

[Kazlauskas, Nicholas]

On 3/22/19 9:49 AM, Paul Menzel wrote:
> Dear Nicholas,
> 
> 
> On 03/22/19 14:15, Nicholas Kazlauskas wrote:
>> The brace initialization used here generates errors on some
>> compilers. Use memset to make this more portable.
> 
> Could you please specify the problematic compiler/toolchain in
> the commit message?
> 
> […]
> 
> 
> Kind regards,
> 
> Paul
> 

I actually meant warning in this case - since I usually build amdgpu 
with warnings as errors. In this case it was an older version of GCC 
that generated the warning (4.9). Though I think clang does as well, I 
forgot to make this patch after I saw the email from Nils Wallménius a 
while back. There were similar issues in a few other places:

https://lists.freedesktop.org/archives/amd-gfx/2019-February/031116.html

I'll update the commit message and post a v2, thanks!

Nicholas Kazlauskas
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx