Re: [PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size"

["Christian König" <ckoenig.leichtzumerken@gmail.com>]

Am 23.08.24 um 15:13 schrieb Alex Deucher:
> Ping?
>
> On Tue, Aug 20, 2024 at 9:46 AM Alex Deucher <alexander.deucher@amd.com> wrote:
>> This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0.
>>
>> This patch causes sluggishness and stuttering in graphical
>> apps.
>>
>> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3564
>> Link: https://www.spinics.net/lists/dri-devel/msg457005.html
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>> Cc: Zhu Lingshan <lingshan.zhu@amd.com>
>> Cc: Christian König <christian.koenig@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

>> ---
>>   include/drm/ttm/ttm_bo.h | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h
>> index ef0f52f56ebc..6ccf96c91f3a 100644
>> --- a/include/drm/ttm/ttm_bo.h
>> +++ b/include/drm/ttm/ttm_bo.h
>> @@ -39,11 +39,7 @@
>>   #include "ttm_device.h"
>>
>>   /* Default number of pre-faulted pages in the TTM fault handler */
>> -#if CONFIG_PGTABLE_LEVELS > 2
>> -#define TTM_BO_VM_NUM_PREFAULT (1 << (PMD_SHIFT - PAGE_SHIFT))
>> -#else
>>   #define TTM_BO_VM_NUM_PREFAULT 16
>> -#endif
>>
>>   struct iosys_map;
>>
>> --
>> 2.46.0
>>