* [PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size"
@ 2024-08-20 13:46 Alex Deucher
2024-08-23 13:13 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2024-08-20 13:46 UTC (permalink / raw)
To: amd-gfx, dri-devel; +Cc: Alex Deucher, Zhu Lingshan, Christian König
This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0.
This patch causes sluggishness and stuttering in graphical
apps.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3564
Link: https://www.spinics.net/lists/dri-devel/msg457005.html
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Zhu Lingshan <lingshan.zhu@amd.com>
Cc: Christian König <christian.koenig@amd.com>
---
include/drm/ttm/ttm_bo.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h
index ef0f52f56ebc..6ccf96c91f3a 100644
--- a/include/drm/ttm/ttm_bo.h
+++ b/include/drm/ttm/ttm_bo.h
@@ -39,11 +39,7 @@
#include "ttm_device.h"
/* Default number of pre-faulted pages in the TTM fault handler */
-#if CONFIG_PGTABLE_LEVELS > 2
-#define TTM_BO_VM_NUM_PREFAULT (1 << (PMD_SHIFT - PAGE_SHIFT))
-#else
#define TTM_BO_VM_NUM_PREFAULT 16
-#endif
struct iosys_map;
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size"
2024-08-20 13:46 [PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size" Alex Deucher
@ 2024-08-23 13:13 ` Alex Deucher
2024-08-23 13:25 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2024-08-23 13:13 UTC (permalink / raw)
To: Alex Deucher; +Cc: amd-gfx, dri-devel, Zhu Lingshan, Christian König
Ping?
On Tue, Aug 20, 2024 at 9:46 AM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0.
>
> This patch causes sluggishness and stuttering in graphical
> apps.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3564
> Link: https://www.spinics.net/lists/dri-devel/msg457005.html
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Zhu Lingshan <lingshan.zhu@amd.com>
> Cc: Christian König <christian.koenig@amd.com>
> ---
> include/drm/ttm/ttm_bo.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h
> index ef0f52f56ebc..6ccf96c91f3a 100644
> --- a/include/drm/ttm/ttm_bo.h
> +++ b/include/drm/ttm/ttm_bo.h
> @@ -39,11 +39,7 @@
> #include "ttm_device.h"
>
> /* Default number of pre-faulted pages in the TTM fault handler */
> -#if CONFIG_PGTABLE_LEVELS > 2
> -#define TTM_BO_VM_NUM_PREFAULT (1 << (PMD_SHIFT - PAGE_SHIFT))
> -#else
> #define TTM_BO_VM_NUM_PREFAULT 16
> -#endif
>
> struct iosys_map;
>
> --
> 2.46.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size"
2024-08-23 13:13 ` Alex Deucher
@ 2024-08-23 13:25 ` Christian König
0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2024-08-23 13:25 UTC (permalink / raw)
To: Alex Deucher, Alex Deucher
Cc: amd-gfx, dri-devel, Zhu Lingshan, Christian König
Am 23.08.24 um 15:13 schrieb Alex Deucher:
> Ping?
>
> On Tue, Aug 20, 2024 at 9:46 AM Alex Deucher <alexander.deucher@amd.com> wrote:
>> This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0.
>>
>> This patch causes sluggishness and stuttering in graphical
>> apps.
>>
>> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3564
>> Link: https://www.spinics.net/lists/dri-devel/msg457005.html
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>> Cc: Zhu Lingshan <lingshan.zhu@amd.com>
>> Cc: Christian König <christian.koenig@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
>> ---
>> include/drm/ttm/ttm_bo.h | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h
>> index ef0f52f56ebc..6ccf96c91f3a 100644
>> --- a/include/drm/ttm/ttm_bo.h
>> +++ b/include/drm/ttm/ttm_bo.h
>> @@ -39,11 +39,7 @@
>> #include "ttm_device.h"
>>
>> /* Default number of pre-faulted pages in the TTM fault handler */
>> -#if CONFIG_PGTABLE_LEVELS > 2
>> -#define TTM_BO_VM_NUM_PREFAULT (1 << (PMD_SHIFT - PAGE_SHIFT))
>> -#else
>> #define TTM_BO_VM_NUM_PREFAULT 16
>> -#endif
>>
>> struct iosys_map;
>>
>> --
>> 2.46.0
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-23 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-20 13:46 [PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size" Alex Deucher
2024-08-23 13:13 ` Alex Deucher
2024-08-23 13:25 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox