Re: [PATCH 12/33] drm/amdgpu: add configurable grace period for unmap queues

[Felix Kuehling <felix.kuehling@amd.com>]

Am 2023-05-25 um 13:27 schrieb Jonathan Kim:
> |diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c 
> b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c index 
> faf4772ed317..a0cfd57ea84a 100644 --- 
> a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c +++ 
> b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c @@ -303,6 +303,7 
> @@ const struct packet_manager_funcs kfd_vi_pm_funcs = { 
> .set_resources = pm_set_resources_vi, .map_queues = pm_map_queues_vi, 
> .unmap_queues = pm_unmap_queues_vi, + .set_grace_period = NULL, 
> .query_status = pm_query_status_vi, .release_mem = pm_release_mem_vi, 
> .map_process_size = sizeof(struct pm4_mes_map_process), @@ -310,6 
> +311,7 @@ const struct packet_manager_funcs kfd_vi_pm_funcs = { 
> .set_resources_size = sizeof(struct pm4_mes_set_resources), 
> .map_queues_size = sizeof(struct pm4_mes_map_queues), 
> .unmap_queues_size = sizeof(struct pm4_mes_unmap_queues), + 
> .set_grace_period = 0,|

|Did you mean set_grace_period_size here? With that fixed, the patch is|

|Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
|


> |.query_status_size = sizeof(struct pm4_mes_query_status), 
> .release_mem_size = sizeof(struct pm4_mec_release_mem)|