From: "Li, Sun peng (Leo)" <Sunpeng.Li-5C7GfCeVMHo@public.gmane.org>
To: "Kazlauskas,
Nicholas" <Nicholas.Kazlauskas-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amd/display: Remove semicolon from to_dm_plane_state definition
Date: Tue, 9 Apr 2019 14:22:42 +0000 [thread overview]
Message-ID: <8fe62bc6-5010-136f-e784-6cddfbe3254a@amd.com> (raw)
In-Reply-To: <20190325192701.6520-1-nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
On 2019-03-25 3:27 p.m., Nicholas Kazlauskas wrote:
> The extra ; in the macro definition creates an empty statement
> preventing any variable declarations from occuring after
> any use of to_dm_plane_state(...).
>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Leo Li <sunpeng.li@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> index 87ca5746f861..94b77488a0e4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> @@ -57,7 +57,7 @@ struct amdgpu_hpd;
> #define to_amdgpu_encoder(x) container_of(x, struct amdgpu_encoder, base)
> #define to_amdgpu_framebuffer(x) container_of(x, struct amdgpu_framebuffer, base)
>
> -#define to_dm_plane_state(x) container_of(x, struct dm_plane_state, base);
> +#define to_dm_plane_state(x) container_of(x, struct dm_plane_state, base)
>
> #define AMDGPU_MAX_HPD_PINS 6
> #define AMDGPU_MAX_CRTCS 6
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-04-09 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 19:27 [PATCH] drm/amd/display: Remove semicolon from to_dm_plane_state definition Nicholas Kazlauskas
[not found] ` <20190325192701.6520-1-nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
2019-04-09 14:22 ` Li, Sun peng (Leo) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fe62bc6-5010-136f-e784-6cddfbe3254a@amd.com \
--to=sunpeng.li-5c7gfcevmho@public.gmane.org \
--cc=Nicholas.Kazlauskas-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox