[PATCH] drm/amd/display: Remove semicolon from to_dm_plane_state definition

[PATCH] drm/amd/display: Remove semicolon from to_dm_plane_state definition

[Nicholas Kazlauskas]

The extra ; in the macro definition creates an empty statement
preventing any variable declarations from occuring after
any use of to_dm_plane_state(...).

Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
index 87ca5746f861..94b77488a0e4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
@@ -57,7 +57,7 @@ struct amdgpu_hpd;
 #define to_amdgpu_encoder(x) container_of(x, struct amdgpu_encoder, base)
 #define to_amdgpu_framebuffer(x) container_of(x, struct amdgpu_framebuffer, base)
 
-#define to_dm_plane_state(x)	container_of(x, struct dm_plane_state, base);
+#define to_dm_plane_state(x)	container_of(x, struct dm_plane_state, base)
 
 #define AMDGPU_MAX_HPD_PINS 6
 #define AMDGPU_MAX_CRTCS 6
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/display: Remove semicolon from to_dm_plane_state definition

[Li, Sun peng (Leo)]

On 2019-03-25 3:27 p.m., Nicholas Kazlauskas wrote:
> The extra ; in the macro definition creates an empty statement
> preventing any variable declarations from occuring after
> any use of to_dm_plane_state(...).
> 
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Reviewed-by: Leo Li <sunpeng.li@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> index 87ca5746f861..94b77488a0e4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> @@ -57,7 +57,7 @@ struct amdgpu_hpd;
>   #define to_amdgpu_encoder(x) container_of(x, struct amdgpu_encoder, base)
>   #define to_amdgpu_framebuffer(x) container_of(x, struct amdgpu_framebuffer, base)
>   
> -#define to_dm_plane_state(x)	container_of(x, struct dm_plane_state, base);
> +#define to_dm_plane_state(x)	container_of(x, struct dm_plane_state, base)
>   
>   #define AMDGPU_MAX_HPD_PINS 6
>   #define AMDGPU_MAX_CRTCS 6
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx