From: Harry Wentland <hwentlan-5C7GfCeVMHo@public.gmane.org>
To: "Kazlauskas,
Nicholas" <Nicholas.Kazlauskas-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "Wentland, Harry" <Harry.Wentland-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amd/display: Add back missing hw translate init for DCN1_01
Date: Fri, 31 May 2019 18:05:22 +0000 [thread overview]
Message-ID: <90dc7bf2-3886-0572-3046-8903bdc83146@amd.com> (raw)
In-Reply-To: <20190531160526.28279-1-nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
On 2019-05-31 12:05 p.m., Nicholas Kazlauskas wrote:
> [Why]
> DCN_VERSION_1_01 is no longer handled in the dal_hw_translate_init
> switch since it was inadvertently dropped in the patch that removed the
> unnecessary DCN1_01 guards.
>
> This caused numerous regressions on DCN1_01 when loading the driver.
>
> [How]
> Add it back.
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Fixes: 97df424fe7a7 ("drm/amd/display: Drop DCN1_01 guards")
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
> index 77615146b96e..1f9833dc8cfe 100644
> --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
> +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
> @@ -81,6 +81,7 @@ bool dal_hw_translate_init(
> return true;
> #if defined(CONFIG_DRM_AMD_DC_DCN1_0)
> case DCN_VERSION_1_0:
> + case DCN_VERSION_1_01:
> dal_hw_translate_dcn10_init(translate);
> return true;
> #endif
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-05-31 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 16:05 [PATCH] drm/amd/display: Add back missing hw translate init for DCN1_01 Nicholas Kazlauskas
[not found] ` <20190531160526.28279-1-nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
2019-05-31 16:39 ` Deucher, Alexander
2019-05-31 18:05 ` Harry Wentland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90dc7bf2-3886-0572-3046-8903bdc83146@amd.com \
--to=hwentlan-5c7gfcevmho@public.gmane.org \
--cc=Harry.Wentland-5C7GfCeVMHo@public.gmane.org \
--cc=Nicholas.Kazlauskas-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox