AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Add back missing hw translate init for DCN1_01
@ 2019-05-31 16:05 Nicholas Kazlauskas
       [not found] ` <20190531160526.28279-1-nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Kazlauskas @ 2019-05-31 16:05 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: Harry Wentland, Nicholas Kazlauskas

[Why]
DCN_VERSION_1_01 is no longer handled in the dal_hw_translate_init
switch since it was inadvertently dropped in the patch that removed the
unnecessary DCN1_01 guards.

This caused numerous regressions on DCN1_01 when loading the driver.

[How]
Add it back.

Cc: Harry Wentland <harry.wentland@amd.com>
Fixes: 97df424fe7a7 ("drm/amd/display: Drop DCN1_01 guards")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
index 77615146b96e..1f9833dc8cfe 100644
--- a/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
+++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
@@ -81,6 +81,7 @@ bool dal_hw_translate_init(
 		return true;
 #if defined(CONFIG_DRM_AMD_DC_DCN1_0)
 	case DCN_VERSION_1_0:
+	case DCN_VERSION_1_01:
 		dal_hw_translate_dcn10_init(translate);
 		return true;
 #endif
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amd/display: Add back missing hw translate init for DCN1_01
       [not found] ` <20190531160526.28279-1-nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
@ 2019-05-31 16:39   ` Deucher, Alexander
  2019-05-31 18:05   ` Harry Wentland
  1 sibling, 0 replies; 3+ messages in thread
From: Deucher, Alexander @ 2019-05-31 16:39 UTC (permalink / raw)
  To: Kazlauskas, Nicholas,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
  Cc: Wentland, Harry


[-- Attachment #1.1: Type: text/plain, Size: 1846 bytes --]

Acked-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Nicholas Kazlauskas <nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
Sent: Friday, May 31, 2019 12:05 PM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Wentland, Harry; Kazlauskas, Nicholas
Subject: [PATCH] drm/amd/display: Add back missing hw translate init for DCN1_01

[Why]
DCN_VERSION_1_01 is no longer handled in the dal_hw_translate_init
switch since it was inadvertently dropped in the patch that removed the
unnecessary DCN1_01 guards.

This caused numerous regressions on DCN1_01 when loading the driver.

[How]
Add it back.

Cc: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
Fixes: 97df424fe7a7 ("drm/amd/display: Drop DCN1_01 guards")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
index 77615146b96e..1f9833dc8cfe 100644
--- a/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
+++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
@@ -81,6 +81,7 @@ bool dal_hw_translate_init(
                 return true;
 #if defined(CONFIG_DRM_AMD_DC_DCN1_0)
         case DCN_VERSION_1_0:
+       case DCN_VERSION_1_01:
                 dal_hw_translate_dcn10_init(translate);
                 return true;
 #endif
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[-- Attachment #1.2: Type: text/html, Size: 3273 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amd/display: Add back missing hw translate init for DCN1_01
       [not found] ` <20190531160526.28279-1-nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
  2019-05-31 16:39   ` Deucher, Alexander
@ 2019-05-31 18:05   ` Harry Wentland
  1 sibling, 0 replies; 3+ messages in thread
From: Harry Wentland @ 2019-05-31 18:05 UTC (permalink / raw)
  To: Kazlauskas, Nicholas,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
  Cc: Wentland, Harry

On 2019-05-31 12:05 p.m., Nicholas Kazlauskas wrote:
> [Why]
> DCN_VERSION_1_01 is no longer handled in the dal_hw_translate_init
> switch since it was inadvertently dropped in the patch that removed the
> unnecessary DCN1_01 guards.
> 
> This caused numerous regressions on DCN1_01 when loading the driver.
> 
> [How]
> Add it back.
> 
> Cc: Harry Wentland <harry.wentland@amd.com>
> Fixes: 97df424fe7a7 ("drm/amd/display: Drop DCN1_01 guards")
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
> index 77615146b96e..1f9833dc8cfe 100644
> --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
> +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
> @@ -81,6 +81,7 @@ bool dal_hw_translate_init(
>  		return true;
>  #if defined(CONFIG_DRM_AMD_DC_DCN1_0)
>  	case DCN_VERSION_1_0:
> +	case DCN_VERSION_1_01:
>  		dal_hw_translate_dcn10_init(translate);
>  		return true;
>  #endif
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-31 18:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-31 16:05 [PATCH] drm/amd/display: Add back missing hw translate init for DCN1_01 Nicholas Kazlauskas
     [not found] ` <20190531160526.28279-1-nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>
2019-05-31 16:39   ` Deucher, Alexander
2019-05-31 18:05   ` Harry Wentland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox