Re: [PATCH 12/13] drm/colorop: Use destroy callback for color pipeline teardown

[Alex Hung <alex.hung@amd.com>]

Reviewed-by: Alex Hung <alex.hung@amd.com>

On 12/18/25 23:56, Chaitanya Kumar Borah wrote:
> Switch drm_colorop_pipeline_destroy() to use the driver-provided
> destroy callback instead of directly calling drm_colorop_cleanup()
> and freeing the object.
> 
> This allows drivers that embed struct drm_colorop in driver-specific
> objects to perform correct teardown.
> 
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
>   drivers/gpu/drm/drm_colorop.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c
> index 4b27804bb0bd..fafe45b93ff8 100644
> --- a/drivers/gpu/drm/drm_colorop.c
> +++ b/drivers/gpu/drm/drm_colorop.c
> @@ -205,8 +205,7 @@ void drm_colorop_pipeline_destroy(struct drm_device *dev)
>   	struct drm_colorop *colorop, *next;
>   
>   	list_for_each_entry_safe(colorop, next, &config->colorop_list, head) {
> -		drm_colorop_cleanup(colorop);
> -		kfree(colorop);
> +		colorop->funcs->destroy(colorop);
>   	}
>   }
>   EXPORT_SYMBOL(drm_colorop_pipeline_destroy);