[PATCH libdrm 0/2] amdgpu: Minor cleanups

[PATCH libdrm 0/2] amdgpu: Minor cleanups

[Michel Dänzer]

From: Michel Dänzer <michel.daenzer@amd.com>

I stumbled over these while working on bigger changes.

Michel Dänzer (2):
  amdgpu: Move union declaration to top of
    amdgpu_cs_ctx_override_priority
  amdgpu: Update amdgpu_bo_handle_type_kms_noimport documentation

 amdgpu/amdgpu.h    | 4 ++--
 amdgpu/amdgpu_cs.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH libdrm 1/2] amdgpu: Move union declaration to top of amdgpu_cs_ctx_override_priority

[Michel Dänzer]

From: Michel Dänzer <michel.daenzer@amd.com>

Avoids compiler warning:

../../amdgpu/amdgpu_cs.c: In function 'amdgpu_cs_ctx_override_priority':
../../amdgpu/amdgpu_cs.c:155:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  union drm_amdgpu_sched args;
  ^~~~~

Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 amdgpu/amdgpu_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c
index 977fa3cf..20d5aef2 100644
--- a/amdgpu/amdgpu_cs.c
+++ b/amdgpu/amdgpu_cs.c
@@ -147,12 +147,12 @@ drm_public int amdgpu_cs_ctx_override_priority(amdgpu_device_handle dev,
                                                int master_fd,
                                                unsigned priority)
 {
+	union drm_amdgpu_sched args;
 	int r;
 
 	if (!dev || !context || master_fd < 0)
 		return -EINVAL;
 
-	union drm_amdgpu_sched args;
 	memset(&args, 0, sizeof(args));
 
 	args.in.op = AMDGPU_SCHED_OP_CONTEXT_PRIORITY_OVERRIDE;
-- 
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH libdrm 2/2] amdgpu: Update amdgpu_bo_handle_type_kms_noimport documentation

[Michel Dänzer]

From: Michel Dänzer <michel.daenzer@amd.com>

To reflect current reality.

Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 amdgpu/amdgpu.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
index 9d9b0832..66e45f73 100644
--- a/amdgpu/amdgpu.h
+++ b/amdgpu/amdgpu.h
@@ -87,8 +87,8 @@ enum amdgpu_bo_handle_type {
 	/** DMA-buf fd handle */
 	amdgpu_bo_handle_type_dma_buf_fd = 2,
 
-	/** KMS handle, but re-importing as a DMABUF handle through
-	 *  drmPrimeHandleToFD is forbidden. (Glamor does that)
+	/** Deprecated in favour of and same behaviour as
+	 * amdgpu_bo_handle_type_kms, use that instead of this
 	 */
 	amdgpu_bo_handle_type_kms_noimport = 3,
 };
-- 
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH libdrm 0/2] amdgpu: Minor cleanups

[Christian König]

Reviewed-by: Christian König <christian.koenig@amd.com> for the series.

Am 24.06.19 um 17:45 schrieb Michel Dänzer:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> I stumbled over these while working on bigger changes.
>
> Michel Dänzer (2):
>    amdgpu: Move union declaration to top of
>      amdgpu_cs_ctx_override_priority
>    amdgpu: Update amdgpu_bo_handle_type_kms_noimport documentation
>
>   amdgpu/amdgpu.h    | 4 ++--
>   amdgpu/amdgpu_cs.c | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx