AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: enable the attributes for vb flashing
@ 2025-01-30  7:37 Mangesh Gadre
  2025-01-30  9:43 ` Lazar, Lijo
  2025-01-30  9:43 ` Lazar, Lijo
  0 siblings, 2 replies; 3+ messages in thread
From: Mangesh Gadre @ 2025-01-30  7:37 UTC (permalink / raw)
  To: amd-gfx, Lijo.Lazar, Hawking.Zhang; +Cc: Mangesh.Gadre, Shiwu Zhang

From: Shiwu Zhang <shiwu.zhang@amd.com>

Make psp_vbflash_status and psp_vbflash available in sysfs

Signed-off-by: Shiwu Zhang <shiwu.zhang@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 4c794e8ca7bd..b531adfb4f57 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -208,11 +208,15 @@ static int psp_early_init(struct amdgpu_ip_block *ip_block)
 		psp->boot_time_tmr = false;
 		fallthrough;
 	case IP_VERSION(13, 0, 6):
-	case IP_VERSION(13, 0, 12):
 	case IP_VERSION(13, 0, 14):
 		psp_v13_0_set_psp_funcs(psp);
 		psp->autoload_supported = false;
 		break;
+	case IP_VERSION(13, 0, 12):
+		psp_v13_0_set_psp_funcs(psp);
+		psp->autoload_supported = false;
+		adev->psp.sup_ifwi_up = !amdgpu_sriov_vf(adev);
+		break;
 	case IP_VERSION(13, 0, 1):
 	case IP_VERSION(13, 0, 3):
 	case IP_VERSION(13, 0, 5):
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: enable the attributes for vb flashing
  2025-01-30  7:37 [PATCH] drm/amdgpu: enable the attributes for vb flashing Mangesh Gadre
@ 2025-01-30  9:43 ` Lazar, Lijo
  2025-01-30  9:43 ` Lazar, Lijo
  1 sibling, 0 replies; 3+ messages in thread
From: Lazar, Lijo @ 2025-01-30  9:43 UTC (permalink / raw)
  To: Mangesh Gadre, amd-gfx, Hawking.Zhang; +Cc: Shiwu Zhang



On 1/30/2025 1:07 PM, Mangesh Gadre wrote:
> From: Shiwu Zhang <shiwu.zhang@amd.com>
> 
> Make psp_vbflash_status and psp_vbflash available in sysfs
> 

Suggest to keep subject like

	Enable IFWI update support on PSPv13.0.12

With that,
	Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> Signed-off-by: Shiwu Zhang <shiwu.zhang@amd.com>
> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 4c794e8ca7bd..b531adfb4f57 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -208,11 +208,15 @@ static int psp_early_init(struct amdgpu_ip_block *ip_block)
>  		psp->boot_time_tmr = false;
>  		fallthrough;
>  	case IP_VERSION(13, 0, 6):
> -	case IP_VERSION(13, 0, 12):
>  	case IP_VERSION(13, 0, 14):
>  		psp_v13_0_set_psp_funcs(psp);
>  		psp->autoload_supported = false;
>  		break;
> +	case IP_VERSION(13, 0, 12):
> +		psp_v13_0_set_psp_funcs(psp);
> +		psp->autoload_supported = false;
> +		adev->psp.sup_ifwi_up = !amdgpu_sriov_vf(adev);
> +		break;
>  	case IP_VERSION(13, 0, 1):
>  	case IP_VERSION(13, 0, 3):
>  	case IP_VERSION(13, 0, 5):


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: enable the attributes for vb flashing
  2025-01-30  7:37 [PATCH] drm/amdgpu: enable the attributes for vb flashing Mangesh Gadre
  2025-01-30  9:43 ` Lazar, Lijo
@ 2025-01-30  9:43 ` Lazar, Lijo
  1 sibling, 0 replies; 3+ messages in thread
From: Lazar, Lijo @ 2025-01-30  9:43 UTC (permalink / raw)
  To: Mangesh Gadre, amd-gfx, Hawking.Zhang; +Cc: Shiwu Zhang



On 1/30/2025 1:07 PM, Mangesh Gadre wrote:
> From: Shiwu Zhang <shiwu.zhang@amd.com>
> 
> Make psp_vbflash_status and psp_vbflash available in sysfs
> 

Suggest to keep subject like

	Enable IFWI update support with PSPv13.0.12

With that,
	Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> Signed-off-by: Shiwu Zhang <shiwu.zhang@amd.com>
> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 4c794e8ca7bd..b531adfb4f57 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -208,11 +208,15 @@ static int psp_early_init(struct amdgpu_ip_block *ip_block)
>  		psp->boot_time_tmr = false;
>  		fallthrough;
>  	case IP_VERSION(13, 0, 6):
> -	case IP_VERSION(13, 0, 12):
>  	case IP_VERSION(13, 0, 14):
>  		psp_v13_0_set_psp_funcs(psp);
>  		psp->autoload_supported = false;
>  		break;
> +	case IP_VERSION(13, 0, 12):
> +		psp_v13_0_set_psp_funcs(psp);
> +		psp->autoload_supported = false;
> +		adev->psp.sup_ifwi_up = !amdgpu_sriov_vf(adev);
> +		break;
>  	case IP_VERSION(13, 0, 1):
>  	case IP_VERSION(13, 0, 3):
>  	case IP_VERSION(13, 0, 5):


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-01-30  9:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-30  7:37 [PATCH] drm/amdgpu: enable the attributes for vb flashing Mangesh Gadre
2025-01-30  9:43 ` Lazar, Lijo
2025-01-30  9:43 ` Lazar, Lijo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox