AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: amd-gfx@lists.freedesktop.org, Alexander.Deucher@amd.com,
	"Christian König" <christian.koenig@amd.com>,
	"Natalie Vock" <natalie.vock@gmx.de>,
	"Marek Olšák" <maraeo@gmail.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	"Felix Kuehling" <Felix.Kuehling@amd.com>,
	"Lazar, Lijo" <lijo.lazar@amd.com>
Subject: Re: [PATCH 3/5] drm/amdgpu/sdma: Move SDMA v5.x queue reset to common code
Date: Fri, 28 Aug 2026 23:49:10 +0200	[thread overview]
Message-ID: <R_iMZNxlTFO2uL1L2693_w@gmail.com> (raw)
In-Reply-To: <CADnq5_M9yN5zMm63PAhLpk_QzfKgmqknhRv6MvH0HKWJYXNQDA@mail.gmail.com>

On 2026. augusztus 28., péntek 17:52:22 közép-európai nyári idő Alex Deucher 
wrote:
> > > 
> > > Instead of moving it here - sdma_v5_x_reset_queue and using it for 5.2
> > > is better. This may not work in the same way for all legacy queues.
> > > 
> > > Thanks,
> > > Lijo
> > 
> > Hi,
> > 
> > As far as I see, this function can be reused for all generations that
> > don't
> > use MES. If you don't think so, please explain why not.
> 
> I think the context is missing that you want to extend this to older
> generations as well and it's still applicable there.
> 
> Alex

Yes, I would like to implement queue reset for all SDMA versions and I would 
like to extend this function to do that.

My main motivation for this is that we want to enable SDMA for older GPU 
generations in RADV. The SDMA will see more use, and therefore the kernel 
needs to handle when the SDMA hangs.

I already have a prototype implementation of the queue reset for SDMA v2 (CIK) 
which makes is much easier to develop the SDMA code in RADV because it can 
recover from hangs without needing me to reboot my computer as I am developing 
and testing the code in RADV.

Thanks & best regards,
Timur



  reply	other threads:[~2026-08-28 21:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 12:07 [PATCH 0/5] drm/amdgpu/sdma: Improve existing SDMA queue resets Timur Kristóf
2026-08-28 12:07 ` [PATCH 1/5] drm/amdgpu/sdma: Clear SDMA rings after reset before starting them Timur Kristóf
2026-08-28 12:07 ` [PATCH 2/5] drm/amdgpu/sdma: Remove unimplemented soft_reset() for SDMA and SI DMA Timur Kristóf
2026-08-28 14:21   ` Lazar, Lijo
2026-08-28 12:07 ` [PATCH 3/5] drm/amdgpu/sdma: Move SDMA v5.x queue reset to common code Timur Kristóf
2026-08-28 14:20   ` Lazar, Lijo
2026-08-28 15:37     ` Timur Kristóf
2026-08-28 15:52       ` Alex Deucher
2026-08-28 21:49         ` Timur Kristóf [this message]
2026-08-28 15:53       ` Lazar, Lijo
2026-08-28 21:42         ` Timur Kristóf
2026-08-28 12:07 ` [PATCH 4/5] drm/amdgpu/sdma: Use common SDMA legacy queue reset on SDMA v4.4.2 Timur Kristóf
2026-08-28 14:16   ` Lazar, Lijo
2026-08-28 15:36     ` Timur Kristóf
2026-08-28 15:46       ` Lazar, Lijo
2026-08-28 12:07 ` [PATCH 5/5] drm/amdgpu/sdma: In legacy queue reset function, check if KFD is initialized Timur Kristóf
2026-08-28 14:11   ` Lazar, Lijo
2026-08-28 15:34     ` Timur Kristóf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=R_iMZNxlTFO2uL1L2693_w@gmail.com \
    --to=timur.kristof@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=lijo.lazar@amd.com \
    --cc=maraeo@gmail.com \
    --cc=mario.limonciello@amd.com \
    --cc=natalie.vock@gmx.de \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox