AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org,
	"Christian König" <christian.koenig@amd.com>
Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: skip the VMID 0 flush for VRAM clear-on-release
Date: Mon, 31 Aug 2026 14:30:20 +0200	[thread overview]
Message-ID: <UJ9MXKXkSh6txd43wHcgSg@gmail.com> (raw)
In-Reply-To: <03347904-e0ee-42ef-a40a-478309a2ba33@amd.com>

On Monday, August 31, 2026 2:13:47 PM Central European Summer Time Christian 
König wrote:
> On 8/31/26 13:39, Timur Kristóf wrote:
> > On 2026. augusztus 28., péntek 6:47:34 közép-európai nyári idő Arunpravin
> > 
> > Paneer Selvam wrote:
> >> Clear-on-release only runs on VRAM, which amdgpu_ttm_map_buffer() reaches
> >> via its direct MC address without programming a GART window, yet the wipe
> >> still forces a VMID 0 flush.
> > 
> > Makes sense.
> > We don't need the VM flush when we are not changing the page tables.
> > 
> > I agree with the patch, just would like to ask a few questions to better
> > 
> > understand the underlying problem:
> >> On GFX11 (e.g. Navi33) that spurious SDMA
> >> flush can wedge the engine
> > 
> > What is happening when the SDMA engine is wedged?
> 
> As far as Arun has investigate the UTCL1 request queue (which is part of the
> memory interface of the SDMA) is in a deadlock, but we haven't quite
> figured out why yet.

> > Can it be recovered by an
> > SDMA queue reset?
> 
> Most likely no. The UTCL1 is the translation and memory request queue
> between SDMA and the core memory hub. To reset that one you need to reset
> both ends and the core memory hub usually needs a full ASIC reset for that.

I see. That's very unfortunate.

> > Is it just a hang, or can it cause other issues such as page faults?
> 
> Good question we honestly don't know at this point. The HW guys need to find
> the root cause first.

> >> only flush when a GART window is actually used.
> > 
> > Does that mean that there is still a risk of the wedge when the GART
> > windows are used?
> 
> Yes, and that is actually not limited to the GART windows. It looks like
> every time we map something into any VM it can happen that the SDMA crashes
> when there are concurrent operations ongoing.

Would it help to set
adev->vm_manager.concurrent_flush = false
until the problem is figured out?
Or can the crash also happen when the VM is not concurrently flushed?

By the way, is this the same issue as the Navi 1 sdma_invalidation_workaround 
or is that completely different?

> It's just that the GART flushes triggered by the SDMA made that scenario
> much more likely than anything else.
> > Can you remind me when/why we need the GART windows exactly?
> 
> Basically every time we want to copy something from system memory to VRAM
> with the kernel.

Understood. Thanks for explaining!

Best regards,
Timur


> 
> >> Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality")
> >> Cc: stable@vger.kernel.org
> >> Cc: Christian König <christian.koenig@amd.com>
> >> Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
> > 
> > Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
> > 




  reply	other threads:[~2026-08-31 12:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28  4:47 [PATCH] drm/amdgpu: skip the VMID 0 flush for VRAM clear-on-release Arunpravin Paneer Selvam
2026-08-28  8:07 ` Christian König
2026-08-31 11:39 ` Timur Kristóf
2026-08-31 12:13   ` Christian König
2026-08-31 12:30     ` Timur Kristóf [this message]
2026-08-31 17:38       ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=UJ9MXKXkSh6txd43wHcgSg@gmail.com \
    --to=timur.kristof@gmail.com \
    --cc=Arunpravin.PaneerSelvam@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox