AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [bug report] drm/amd/display: Various logs added
@ 2023-02-27  7:12 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2023-02-27  7:12 UTC (permalink / raw)
  To: sancchen; +Cc: amd-gfx

Hello Leo Chen,

This is a semi-automatic email about new static checker warnings.

The patch 7ef414375fcc: "drm/amd/display: Various logs added" from 
Aug 29, 2022, leads to the following Smatch complaint:

    ./drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c:1862 get_firmware_info_v3_2()
    warn: variable dereferenced before check 'smu_info_v3_2' (see line 1861)

./drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
  1860								DATA_TABLES(smu_info));
  1861			DC_LOG_BIOS("gpuclk_ss_percentage (unit of 0.001 percent): %d\n", smu_info_v3_2->gpuclk_ss_percentage);
                                                                                          ^^^^^^^^^^^^^^^
Log adds a crash.

  1862			if (!smu_info_v3_2)
                             ^^^^^^^^^^^^^
Too late.

  1863				return BP_RESULT_BADBIOSTABLE;
  1864	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-27  9:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-27  7:12 [bug report] drm/amd/display: Various logs added Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox