* [PATCH] drm/amdgpu: set gfx9 onwards APU atomics support to be true
@ 2023-04-30 2:02 Yifan Zhang
2023-05-01 15:05 ` Felix Kuehling
2023-05-02 13:50 ` Lang Yu
0 siblings, 2 replies; 3+ messages in thread
From: Yifan Zhang @ 2023-04-30 2:02 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Yifan Zhang, Felix.Kuehling, Christian.Koenig
APUs w/ gfx9 onwards doesn't reply on PCIe atomics, rather
it is internal path w/ native atomic support. Set have_atomics_support
to true.
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index b57e7776055b..750eaffa81ba 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3757,6 +3757,12 @@ int amdgpu_device_init(struct amdgpu_device *adev,
adev->have_atomics_support = ((struct amd_sriov_msg_pf2vf_info *)
adev->virt.fw_reserve.p_pf2vf)->pcie_atomic_ops_support_flags ==
(PCI_EXP_DEVCAP2_ATOMIC_COMP32 | PCI_EXP_DEVCAP2_ATOMIC_COMP64);
+ /* APUs w/ gfx9 onwards doesn't reply on PCIe atomics, rather it is a
+ * internal path natively support atomics, set have_atomics_support to true.
+ */
+ else if ((adev->flags & AMD_IS_APU) &&
+ (adev->ip_versions[GC_HWIP][0] > IP_VERSION(9, 0, 0)))
+ adev->have_atomics_support = true;
else
adev->have_atomics_support =
!pci_enable_atomic_ops_to_root(adev->pdev,
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: set gfx9 onwards APU atomics support to be true
2023-04-30 2:02 [PATCH] drm/amdgpu: set gfx9 onwards APU atomics support to be true Yifan Zhang
@ 2023-05-01 15:05 ` Felix Kuehling
2023-05-02 13:50 ` Lang Yu
1 sibling, 0 replies; 3+ messages in thread
From: Felix Kuehling @ 2023-05-01 15:05 UTC (permalink / raw)
To: Yifan Zhang, amd-gfx; +Cc: Alexander.Deucher, Christian.Koenig
Am 2023-04-29 um 22:02 schrieb Yifan Zhang:
> APUs w/ gfx9 onwards doesn't reply on PCIe atomics, rather
> it is internal path w/ native atomic support. Set have_atomics_support
> to true.
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index b57e7776055b..750eaffa81ba 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3757,6 +3757,12 @@ int amdgpu_device_init(struct amdgpu_device *adev,
> adev->have_atomics_support = ((struct amd_sriov_msg_pf2vf_info *)
> adev->virt.fw_reserve.p_pf2vf)->pcie_atomic_ops_support_flags ==
> (PCI_EXP_DEVCAP2_ATOMIC_COMP32 | PCI_EXP_DEVCAP2_ATOMIC_COMP64);
> + /* APUs w/ gfx9 onwards doesn't reply on PCIe atomics, rather it is a
> + * internal path natively support atomics, set have_atomics_support to true.
> + */
> + else if ((adev->flags & AMD_IS_APU) &&
> + (adev->ip_versions[GC_HWIP][0] > IP_VERSION(9, 0, 0)))
> + adev->have_atomics_support = true;
> else
> adev->have_atomics_support =
> !pci_enable_atomic_ops_to_root(adev->pdev,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: set gfx9 onwards APU atomics support to be true
2023-04-30 2:02 [PATCH] drm/amdgpu: set gfx9 onwards APU atomics support to be true Yifan Zhang
2023-05-01 15:05 ` Felix Kuehling
@ 2023-05-02 13:50 ` Lang Yu
1 sibling, 0 replies; 3+ messages in thread
From: Lang Yu @ 2023-05-02 13:50 UTC (permalink / raw)
To: Yifan Zhang; +Cc: Alexander.Deucher, Felix.Kuehling, Christian.Koenig, amd-gfx
On 04/30/ , Yifan Zhang wrote:
> APUs w/ gfx9 onwards doesn't reply on PCIe atomics, rather
> it is internal path w/ native atomic support. Set have_atomics_support
> to true.
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Reviewed-by: Lang Yu <lang.yu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index b57e7776055b..750eaffa81ba 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3757,6 +3757,12 @@ int amdgpu_device_init(struct amdgpu_device *adev,
> adev->have_atomics_support = ((struct amd_sriov_msg_pf2vf_info *)
> adev->virt.fw_reserve.p_pf2vf)->pcie_atomic_ops_support_flags ==
> (PCI_EXP_DEVCAP2_ATOMIC_COMP32 | PCI_EXP_DEVCAP2_ATOMIC_COMP64);
> + /* APUs w/ gfx9 onwards doesn't reply on PCIe atomics, rather it is a
> + * internal path natively support atomics, set have_atomics_support to true.
> + */
> + else if ((adev->flags & AMD_IS_APU) &&
> + (adev->ip_versions[GC_HWIP][0] > IP_VERSION(9, 0, 0)))
> + adev->have_atomics_support = true;
> else
> adev->have_atomics_support =
> !pci_enable_atomic_ops_to_root(adev->pdev,
> --
> 2.37.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-02 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-30 2:02 [PATCH] drm/amdgpu: set gfx9 onwards APU atomics support to be true Yifan Zhang
2023-05-01 15:05 ` Felix Kuehling
2023-05-02 13:50 ` Lang Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox