* [PATCH] drm/amdgpu: fix doorbell regression
@ 2024-04-29 12:50 Shashank Sharma
2024-04-29 12:52 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Shashank Sharma @ 2024-04-29 12:50 UTC (permalink / raw)
To: amd-gfx; +Cc: Shashank Sharma, Christian Koenig, Alex Deucher, Arvind Yadav
This patch adds a missed handling of PL domain doorbell while
handling VRAM faults.
Fixes: a6ff969fe9cb ("drm/amdgpu: fix visible VRAM handling during faults")
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Shashank Sharma <shashank.sharma@amd.com>
Signed-off-by: Arvind Yadav <arvind.yadav@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 1d71729e3f6b..c71eeb6a04e6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -419,7 +419,7 @@ bool amdgpu_res_cpu_visible(struct amdgpu_device *adev,
return false;
if (res->mem_type == TTM_PL_SYSTEM || res->mem_type == TTM_PL_TT ||
- res->mem_type == AMDGPU_PL_PREEMPT)
+ res->mem_type == AMDGPU_PL_PREEMPT || res->mem_type == AMDGPU_PL_DOORBELL)
return true;
if (res->mem_type != TTM_PL_VRAM)
--
2.43.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amdgpu: fix doorbell regression
2024-04-29 12:50 [PATCH] drm/amdgpu: fix doorbell regression Shashank Sharma
@ 2024-04-29 12:52 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2024-04-29 12:52 UTC (permalink / raw)
To: Shashank Sharma, amd-gfx; +Cc: Alex Deucher, Arvind Yadav
Am 29.04.24 um 14:50 schrieb Shashank Sharma:
> This patch adds a missed handling of PL domain doorbell while
> handling VRAM faults.
>
> Fixes: a6ff969fe9cb ("drm/amdgpu: fix visible VRAM handling during faults")
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Shashank Sharma <shashank.sharma@amd.com>
> Signed-off-by: Arvind Yadav <arvind.yadav@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 1d71729e3f6b..c71eeb6a04e6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -419,7 +419,7 @@ bool amdgpu_res_cpu_visible(struct amdgpu_device *adev,
> return false;
>
> if (res->mem_type == TTM_PL_SYSTEM || res->mem_type == TTM_PL_TT ||
> - res->mem_type == AMDGPU_PL_PREEMPT)
> + res->mem_type == AMDGPU_PL_PREEMPT || res->mem_type == AMDGPU_PL_DOORBELL)
> return true;
>
> if (res->mem_type != TTM_PL_VRAM)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-29 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 12:50 [PATCH] drm/amdgpu: fix doorbell regression Shashank Sharma
2024-04-29 12:52 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox