AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
	"Christian König" <christian.koenig@amd.com>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	chris@chris-wilson.co.uk,
	"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>
Subject: Re: Lockdep spalt on killing a processes
Date: Wed, 27 Oct 2021 10:47:01 -0400	[thread overview]
Message-ID: <a1f594de-e326-6150-c787-35a4fde648d7@amd.com> (raw)
In-Reply-To: <c5fc1be1-eaec-a57c-79ee-9a63123ed9a2@gmail.com>


On 2021-10-27 10:34 a.m., Christian König wrote:
> Am 27.10.21 um 16:27 schrieb Andrey Grodzovsky:
>> [SNIP]
>>>
>>>> Let me please know if I am still missing some point of yours.
>>>
>>> Well, I mean we need to be able to handle this for all drivers.
>>
>>
>> For sure, but as i said above in my opinion we need to change only 
>> for those drivers that don't use the _locked version.
>
> And that absolutely won't work.
>
> See the dma_fence is a contract between drivers, so you need the same 
> calling convention between all drivers.
>
> Either we always call the callback with the lock held or we always 
> call it without the lock, but sometimes like that and sometimes 
> otherwise won't work.
>
> Christian.


I am not sure I fully understand what problems this will cause but 
anyway, then we are back to irq_work. We cannot embed irq_work as union 
within dma_fenc's cb_list
because it's already reused as timestamp and as rcu head after the fence 
is signaled. So I will do it within drm_scheduler with single irq_work 
per drm_sched_entity
as we discussed before.

Andrey


>
>>
>> Andrey
>

  reply	other threads:[~2021-10-27 14:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 10:50 Lockdep spalt on killing a processes Christian König
2021-10-01 14:52 ` Daniel Vetter
2021-10-01 15:10 ` Andrey Grodzovsky
2021-10-04  8:14   ` Christian König
2021-10-04 15:27     ` Andrey Grodzovsky
2021-10-20 19:32     ` Andrey Grodzovsky
2021-10-21  6:34       ` Christian König
2021-10-25 19:10         ` Andrey Grodzovsky
2021-10-25 19:56           ` Christian König
2021-10-26  2:33             ` Andrey Grodzovsky
2021-10-26 10:54               ` Christian König
2021-10-27 14:27                 ` Andrey Grodzovsky
2021-10-27 14:34                   ` Christian König
2021-10-27 14:47                     ` Andrey Grodzovsky [this message]
2021-10-27 14:50                       ` Christian König
2021-10-27 19:58                         ` Andrey Grodzovsky
2021-10-28 17:26                           ` Andrey Grodzovsky
2021-10-29  7:07                             ` Christian König
2021-11-01 15:24                               ` Andrey Grodzovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1f594de-e326-6150-c787-35a4fde648d7@amd.com \
    --to=andrey.grodzovsky@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=christian.koenig@amd.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox