From: Dan Carpenter <dan.carpenter@linaro.org>
To: YiPeng Chai <YiPeng.Chai@amd.com>
Cc: amd-gfx@lists.freedesktop.org, "SHANMUGAM,
SRINIVASAN" <SRINIVASAN.SHANMUGAM@amd.com>
Subject: [bug report] drm/amd/ras: Add rascore unified interface function
Date: Wed, 22 Oct 2025 14:03:48 +0300 [thread overview]
Message-ID: <aPi6FB3E-LNbVYQB@stanley.mountain> (raw)
Hello YiPeng Chai,
Commit 13c91b5b4378 ("drm/amd/ras: Add rascore unified interface
function") from Mar 17, 2025 (linux-next), leads to the following
Smatch static checker warning:
drivers/gpu/drm/amd/amdgpu/../ras/rascore/ras_core.c:531 ras_core_ras_interrupt_detected()
error: we previously assumed 'ras_core' could be null (see line 527)
drivers/gpu/drm/amd/amdgpu/../ras/rascore/ras_core.c
525 bool ras_core_ras_interrupt_detected(struct ras_core_context *ras_core)
526 {
527 if (ras_core && ras_core->sys_fn &&
^^^^^^^^
If ras_core is NULL
528 ras_core->sys_fn->detect_ras_interrupt)
529 return ras_core->sys_fn->detect_ras_interrupt(ras_core);
530
--> 531 RAS_DEV_ERR(ras_core->dev, "Failed to detect ras interrupt!\n");
^^^^^^^^^^^^^
Then we are toasted
532 return false;
533 }
regards,
dan carpenter
reply other threads:[~2025-10-23 7:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPi6FB3E-LNbVYQB@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=SRINIVASAN.SHANMUGAM@amd.com \
--cc=YiPeng.Chai@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox