* [bug report] drm/amd/ras: Add rascore unified interface function
@ 2025-10-22 11:03 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2025-10-22 11:03 UTC (permalink / raw)
To: YiPeng Chai; +Cc: amd-gfx, SHANMUGAM, SRINIVASAN
Hello YiPeng Chai,
Commit 13c91b5b4378 ("drm/amd/ras: Add rascore unified interface
function") from Mar 17, 2025 (linux-next), leads to the following
Smatch static checker warning:
drivers/gpu/drm/amd/amdgpu/../ras/rascore/ras_core.c:531 ras_core_ras_interrupt_detected()
error: we previously assumed 'ras_core' could be null (see line 527)
drivers/gpu/drm/amd/amdgpu/../ras/rascore/ras_core.c
525 bool ras_core_ras_interrupt_detected(struct ras_core_context *ras_core)
526 {
527 if (ras_core && ras_core->sys_fn &&
^^^^^^^^
If ras_core is NULL
528 ras_core->sys_fn->detect_ras_interrupt)
529 return ras_core->sys_fn->detect_ras_interrupt(ras_core);
530
--> 531 RAS_DEV_ERR(ras_core->dev, "Failed to detect ras interrupt!\n");
^^^^^^^^^^^^^
Then we are toasted
532 return false;
533 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-10-23 7:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-22 11:03 [bug report] drm/amd/ras: Add rascore unified interface function Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox