AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>,
	alexander.deucher@amd.com, Christian.Koenig@amd.com,
	amd-gfx@lists.freedesktop.org
Cc: aurabindo.pillai@amd.com, alex.hung@amd.com
Subject: Re: [PATCH] drm/amd/display: add proper error message for vblank init
Date: Fri, 21 Mar 2025 09:10:54 -0500	[thread overview]
Message-ID: <b2f6aa2c-3f56-4d93-90f7-2712aa3d4174@amd.com> (raw)
In-Reply-To: <20250321113704.390163-1-saleemkhan.jamadar@amd.com>

On 3/21/2025 06:37, Saleemkhan Jamadar wrote:
> Update message to identifiy the vblank initialization fail case
> 
> Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8dd9bf58eac5..3decf1973c7d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2218,7 +2218,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>   
>   	if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
>   		DRM_ERROR(
> -		"amdgpu: failed to initialize sw for display support.\n");
> +		"amdgpu: failed to initialize vblank sw for display support.\n");
>   		goto error;
>   	}
>   

While touching this could you please swap away from DRM_ERROR() to 
drm_err()?

      parent reply	other threads:[~2025-03-21 14:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 11:37 [PATCH] drm/amd/display: add proper error message for vblank init Saleemkhan Jamadar
2025-03-21 12:52 ` Rodrigo Siqueira
2025-03-21 14:10 ` Mario Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2f6aa2c-3f56-4d93-90f7-2712aa3d4174@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=alex.hung@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aurabindo.pillai@amd.com \
    --cc=saleemkhan.jamadar@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox